From e7f24d01c87926b57d5f39c8760a2e8e3dfb92e7 Mon Sep 17 00:00:00 2001 From: Ming Rui Zhang Date: Thu, 8 Oct 2020 15:25:16 -0400 Subject: [PATCH] settingsview: update banned contact correctly Prevent the issue of hidden banned contact ui when new contact request is received Change-Id: I6b6b5c1e702a5fcb23a1ac26efb7df814bce01a8 --- src/settingsview/components/BannedContacts.qml | 6 +----- src/settingsview/components/CurrentAccountSettings.qml | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/settingsview/components/BannedContacts.qml b/src/settingsview/components/BannedContacts.qml index d96fab01..c7e1e229 100644 --- a/src/settingsview/components/BannedContacts.qml +++ b/src/settingsview/components/BannedContacts.qml @@ -70,13 +70,9 @@ ColumnLayout { updateAndShowBannedContactsSlot() } - function setVisibility() { - root.visible = bannedListWidget.model.rowCount() > 0 - } - function updateAndShowBannedContactsSlot() { bannedListWidget.model.reset() - setVisibility() + root.visible = bannedListWidget.model.rowCount() > 0 if(bannedListWidget.model.rowCount() <= 0) { bannedListWidget.visible = false bannedContactsBtn.visible = false diff --git a/src/settingsview/components/CurrentAccountSettings.qml b/src/settingsview/components/CurrentAccountSettings.qml index 4f0484ed..b75daaf1 100644 --- a/src/settingsview/components/CurrentAccountSettings.qml +++ b/src/settingsview/components/CurrentAccountSettings.qml @@ -55,7 +55,7 @@ Rectangle { accountProfile.updateAccountInfo() userIdentity.updateAccountInfo() linkedDevices.updateAndShowDevicesSlot() - bannedContacts.setVisibility() + bannedContacts.updateAndShowBannedContactsSlot() advancedSettings.updateAdvancedAccountInfos() setPasswordButtonText() }