mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-26 10:25:32 +02:00
Code Issues Wiki Activity

Add FIXME comments for future Terminal API.

Browse source
This commit is contained in:
Martin Oberhuber 2008-12-18 17:03:57 +00:00
parent 80035e3361
commit 028fc5c617
2 changed files with 17 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/ITerminalConnector.java
View file

@ -125,10 +125,14 @@ public interface ITerminalConnector extends IAdaptable {
void save(ISettingsStore store); void save(ISettingsStore store);
/** /**
* @return a new page that can be used in a dialog to setup this connection. * FIXME should not have UI related stuff in ITerminalConnector, since
* The dialog should persist its settings with the {@link #load(ISettingsStore)} * connectors may be totally programmatic and UI-less. Better make the
* and {@link #save(ISettingsStore)} methods. * connector adapt to an interface that controls the UI aspect.
* *
* @return a new page that can be used in a dialog to setup this connection.
* The dialog should persist its settings with the
* {@link #load(ISettingsStore)} and {@link #save(ISettingsStore)}
* methods.
*/ */
ISettingsPage makeSettingsPage(); ISettingsPage makeSettingsPage();

2
terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/TerminalState.java
View file

@ -30,7 +30,7 @@ public class TerminalState {
public final static TerminalState CLOSED=new TerminalState("CLOSED"); //$NON-NLS-1$ public final static TerminalState CLOSED=new TerminalState("CLOSED"); //$NON-NLS-1$
/** /**
* TODO: Michael Scharf: it's not clear to me what the meaning of the open state is * FIXME Get rid of this state it is equivalent to CONNECTING.
*/ */
public final static TerminalState OPENED=new TerminalState("OPENED"); //$NON-NLS-1$ public final static TerminalState OPENED=new TerminalState("OPENED"); //$NON-NLS-1$