mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-25 18:05:33 +02:00
Code Issues Wiki Activity

Add FIXME comments for future Terminal API.

Browse source
This commit is contained in:
Martin Oberhuber 2008-12-18 17:03:57 +00:00
parent 80035e3361
commit 028fc5c617
2 changed files with 17 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/ITerminalConnector.java
View file

@ -29,14 +29,14 @@ import org.eclipse.tm.internal.terminal.provisional.api.provider.TerminalConnect
* communications. This pattern allows for lazy initialization, bundle * communications. This pattern allows for lazy initialization, bundle
* activation and class loading of the actual {@link TerminalConnectorImpl} * activation and class loading of the actual {@link TerminalConnectorImpl}
* instance. * instance.
* *
* Clients can get terminal connector instances from the * Clients can get terminal connector instances from the
* {@link TerminalConnectorExtension} class, or from * {@link TerminalConnectorExtension} class, or from
* {@link ITerminalViewControl#getTerminalConnector()} when running inside an * {@link ITerminalViewControl#getTerminalConnector()} when running inside an
* active terminal widget. * active terminal widget.
* *
* @noimplement This interface is not intended to be implemented by clients. * @noimplement This interface is not intended to be implemented by clients.
* *
* @author Michael Scharf * @author Michael Scharf
* <p> * <p>
* <strong>EXPERIMENTAL</strong>. This class or interface has been * <strong>EXPERIMENTAL</strong>. This class or interface has been
@ -125,10 +125,14 @@ public interface ITerminalConnector extends IAdaptable {
void save(ISettingsStore store); void save(ISettingsStore store);
/** /**
* FIXME should not have UI related stuff in ITerminalConnector, since
* connectors may be totally programmatic and UI-less. Better make the
* connector adapt to an interface that controls the UI aspect.
*
* @return a new page that can be used in a dialog to setup this connection. * @return a new page that can be used in a dialog to setup this connection.
* The dialog should persist its settings with the {@link #load(ISettingsStore)} * The dialog should persist its settings with the
* and {@link #save(ISettingsStore)} methods. * {@link #load(ISettingsStore)} and {@link #save(ISettingsStore)}
* * methods.
*/ */
ISettingsPage makeSettingsPage(); ISettingsPage makeSettingsPage();

14
terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/TerminalState.java
View file

@ -1,11 +1,11 @@
/******************************************************************************* /*******************************************************************************
* Copyright (c) 2006, 2007 Wind River Systems, Inc. and others. * Copyright (c) 2006, 2007 Wind River Systems, Inc. and others.
* All rights reserved. This program and the accompanying materials * All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0 * are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at * which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html * http://www.eclipse.org/legal/epl-v10.html
* *
* Contributors: * Contributors:
* Michael Scharf (Wind River) - initial API and implementation * Michael Scharf (Wind River) - initial API and implementation
* Martin Oberhuber (Wind River) - fixed copyright headers and beautified * Martin Oberhuber (Wind River) - fixed copyright headers and beautified
*******************************************************************************/ *******************************************************************************/
@ -30,7 +30,7 @@ public class TerminalState {
public final static TerminalState CLOSED=new TerminalState("CLOSED"); //$NON-NLS-1$ public final static TerminalState CLOSED=new TerminalState("CLOSED"); //$NON-NLS-1$
/** /**
* TODO: Michael Scharf: it's not clear to me what the meaning of the open state is * FIXME Get rid of this state it is equivalent to CONNECTING.
*/ */
public final static TerminalState OPENED=new TerminalState("OPENED"); //$NON-NLS-1$ public final static TerminalState OPENED=new TerminalState("OPENED"); //$NON-NLS-1$