From 0473138b522dd8fe4ab72f2b01bf1b795c5e594a Mon Sep 17 00:00:00 2001 From: Alena Laskavaia Date: Fri, 30 Jan 2009 15:43:51 +0000 Subject: [PATCH] - avoid thrown exception by doing preventive check --- .../model/ICProjectDescriptionStorageType.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/ICProjectDescriptionStorageType.java b/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/ICProjectDescriptionStorageType.java index 4c80d77224a..4970e4e9037 100644 --- a/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/ICProjectDescriptionStorageType.java +++ b/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/ICProjectDescriptionStorageType.java @@ -103,13 +103,15 @@ public interface ICProjectDescriptionStorageType { } private static Version getVersion(IConfigurationElement element, String id, Version defaultValue) throws IllegalArgumentException{ - if (defaultValue == null) - return new Version(element.getAttribute(id)); - Version v = defaultValue; + String value = element.getAttribute(id); + if (value==null) + return defaultValue; + Version v; try { - v = new Version(element.getAttribute(id)); + v = new Version(value); } catch (Exception e) { // If an exception occurred return the default value + v = defaultValue; } return v; }