mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-09 01:05:38 +02:00
Code Issues Wiki Activity

bug 288032: cleanup, @Overrides

Browse source
This commit is contained in:
Andrew Gvozdev 2009-08-30 02:30:12 +00:00
parent 52a34918ad
commit 0c33320268
1 changed files with 18 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
build/org.eclipse.cdt.make.ui/src/org/eclipse/cdt/make/ui/dialogs/GCCPerFileSCDProfilePage.java
View file

@ -65,7 +65,7 @@ public class GCCPerFileSCDProfilePage extends AbstractDiscoveryPage {
// Add the profile UI contribution. // Add the profile UI contribution.
Group profileGroup = ControlFactory.createGroup(page, Group profileGroup = ControlFactory.createGroup(page,
MakeUIPlugin.getResourceString(PROFILE_GROUP_LABEL), 3); MakeUIPlugin.getResourceString("ScannerConfigOptionsDialog.profile.group.label"), 3); //$NON-NLS-1$
GridData gd = (GridData) profileGroup.getLayoutData(); GridData gd = (GridData) profileGroup.getLayoutData();
gd.grabExcessHorizontalSpace = true; gd.grabExcessHorizontalSpace = true;
@ -80,7 +80,8 @@ public class GCCPerFileSCDProfilePage extends AbstractDiscoveryPage {
((GridData)bopEnabledButton.getLayoutData()).grabExcessHorizontalSpace = true; ((GridData)bopEnabledButton.getLayoutData()).grabExcessHorizontalSpace = true;
bopEnabledButton.addSelectionListener(new SelectionAdapter() { bopEnabledButton.addSelectionListener(new SelectionAdapter() {
public void widgetSelected(SelectionEvent e) { @Override
public void widgetSelected(SelectionEvent e) {
handleModifyOpenFileText(); handleModifyOpenFileText();
} }
@ -95,7 +96,8 @@ public class GCCPerFileSCDProfilePage extends AbstractDiscoveryPage {
((GridData) bopLoadButton.getLayoutData()).minimumWidth = 120; ((GridData) bopLoadButton.getLayoutData()).minimumWidth = 120;
bopLoadButton.addSelectionListener(new SelectionAdapter() { bopLoadButton.addSelectionListener(new SelectionAdapter() {
public void widgetSelected(SelectionEvent event) { @Override
public void widgetSelected(SelectionEvent event) {
handleBOPLoadFileButtonSelected(); handleBOPLoadFileButtonSelected();
} }
@ -118,7 +120,8 @@ public class GCCPerFileSCDProfilePage extends AbstractDiscoveryPage {
((GridData) browseButton.getLayoutData()).minimumWidth = 120; ((GridData) browseButton.getLayoutData()).minimumWidth = 120;
browseButton.addSelectionListener(new SelectionAdapter() { browseButton.addSelectionListener(new SelectionAdapter() {
public void widgetSelected(SelectionEvent event) { @Override
public void widgetSelected(SelectionEvent event) {
handleBOPBrowseButtonSelected(); handleBOPBrowseButtonSelected();
} }
@ -216,7 +219,8 @@ public class GCCPerFileSCDProfilePage extends AbstractDiscoveryPage {
readerJob.setPriority(Job.LONG); readerJob.setPriority(Job.LONG);
readerJob.addJobChangeListener(new JobChangeAdapter() { readerJob.addJobChangeListener(new JobChangeAdapter() {
public void done(IJobChangeEvent event) { @Override
public void done(IJobChangeEvent event) {
//lock.acquire(); //lock.acquire();
synchronized (lock) { synchronized (lock) {
if (!instance.shell.isDisposed()) { if (!instance.shell.isDisposed()) {
@ -248,14 +252,16 @@ public class GCCPerFileSCDProfilePage extends AbstractDiscoveryPage {
/* (non-Javadoc) /* (non-Javadoc)
* @see org.eclipse.cdt.make.ui.dialogs.AbstractDiscoveryPage#isValid() * @see org.eclipse.cdt.make.ui.dialogs.AbstractDiscoveryPage#isValid()
*/ */
protected boolean isValid() { @Override
protected boolean isValid() {
return true; return true;
} }
/* (non-Javadoc) /* (non-Javadoc)
* @see org.eclipse.cdt.make.ui.dialogs.AbstractDiscoveryPage#populateBuildInfo(org.eclipse.cdt.make.core.scannerconfig.IScannerConfigBuilderInfo2) * @see org.eclipse.cdt.make.ui.dialogs.AbstractDiscoveryPage#populateBuildInfo(org.eclipse.cdt.make.core.scannerconfig.IScannerConfigBuilderInfo2)
*/ */
protected void populateBuildInfo(IScannerConfigBuilderInfo2 buildInfo) { @Override
protected void populateBuildInfo(IScannerConfigBuilderInfo2 buildInfo) {
if (buildInfo != null) { if (buildInfo != null) {
buildInfo.setBuildOutputFileActionEnabled(true); buildInfo.setBuildOutputFileActionEnabled(true);
buildInfo.setBuildOutputFilePath(getBopOpenFileText()); buildInfo.setBuildOutputFilePath(getBopOpenFileText());
@ -267,7 +273,8 @@ public class GCCPerFileSCDProfilePage extends AbstractDiscoveryPage {
/* (non-Javadoc) /* (non-Javadoc)
* @see org.eclipse.cdt.make.ui.dialogs.AbstractDiscoveryPage#restoreFromBuildinfo(org.eclipse.cdt.make.core.scannerconfig.IScannerConfigBuilderInfo2) * @see org.eclipse.cdt.make.ui.dialogs.AbstractDiscoveryPage#restoreFromBuildinfo(org.eclipse.cdt.make.core.scannerconfig.IScannerConfigBuilderInfo2)
*/ */
protected void restoreFromBuildinfo(IScannerConfigBuilderInfo2 buildInfo) { @Override
protected void restoreFromBuildinfo(IScannerConfigBuilderInfo2 buildInfo) {
if (buildInfo != null) { if (buildInfo != null) {
setBopOpenFileText(buildInfo.getBuildOutputFilePath()); setBopOpenFileText(buildInfo.getBuildOutputFilePath());
bopEnabledButton.setSelection(buildInfo.isBuildOutputParserEnabled()); bopEnabledButton.setSelection(buildInfo.isBuildOutputParserEnabled());
@ -277,10 +284,10 @@ public class GCCPerFileSCDProfilePage extends AbstractDiscoveryPage {
private String getProviderIDForSelectedProfile() { private String getProviderIDForSelectedProfile() {
IScannerConfigBuilderInfo2 builderInfo = getContainer().getBuildInfo(); IScannerConfigBuilderInfo2 builderInfo = getContainer().getBuildInfo();
// Provider IDs for selected profile // Provider IDs for selected profile
List providerIDs = builderInfo.getProviderIdList(); List<String> providerIDs = builderInfo.getProviderIdList();
if(providerIDs.size() == 0) if(providerIDs.size() == 0)
return ""; return ""; //$NON-NLS-1$
return (String)providerIDs.iterator().next(); return providerIDs.iterator().next();
} }
} }