From 1401578875bf5c78c9a3a67be1aae03b2788ade8 Mon Sep 17 00:00:00 2001 From: Sergey Prigogin Date: Sun, 25 Dec 2011 11:15:52 -0800 Subject: [PATCH] Bug 367473 - Rename refactoring without dialog leaks memory. --- .../cdt/internal/ui/refactoring/rename/RenameSupport.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/rename/RenameSupport.java b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/rename/RenameSupport.java index f54d36a7df5..df251517fbe 100644 --- a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/rename/RenameSupport.java +++ b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/refactoring/rename/RenameSupport.java @@ -200,7 +200,11 @@ public class RenameSupport { processor.getSaveMode())) { return DialogResult.OK; } - return dialogSkipped[0] ? DialogResult.SKIPPED : DialogResult.CANCELED; + if (dialogSkipped[0]) { + // If the dialog was not shown, it is our responsibility to close it. + wizard.getContainer().getShell().close(); + return DialogResult.SKIPPED; + } } finally { processor.unlockIndex(); }