mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-23 16:23:52 +02:00
Code Issues Wiki Activity

Bug 510924 - Alt+Enter on breakpoint shows incomplete properties dialog

Browse source 
When using the "Alt-Enter" shortcut with a breakpoint selected, the
properties dialog that is created is missing some fields. This seems to
be caused by the fact that the dialog, when summoned in this way, is
created using a wrong context: an ICLineBreakpoint instead of the
expected CBreakpointContext. That context is then used to fetch
properties from the store, which fails.

This is a naive fix that attempts to work around this by creating a
proper context from the breakpoint.

Change-Id: I2b7c86965d09898dd1cd7eeb3c3f704bb2995e20
(cherry picked from commit 86189eeb86)
This commit is contained in:
Marc Dumais 2017-02-03 08:25:23 -05:00
parent 0e074ad3c1
commit 143f85b06e
3 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/breakpoints/CBreakpointPropertyPage.java
View file

@ -979,7 +979,12 @@ public class CBreakpointPropertyPage extends FieldEditorPreferencePage implement
*/
@Override
public void setElement( IAdaptable element ) {
fElement = element;
if (element instanceof ICBreakpoint) {
fElement = new CBreakpointContext((ICBreakpoint)element, null);
}
else {
fElement = element;
}
}
protected String[] getDebugModelIds() {

7
dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/breakpoints/GDBDynamicPrintfPropertyPage.java
View file

@ -477,7 +477,12 @@ public class GDBDynamicPrintfPropertyPage extends FieldEditorPreferencePage impl
*/
@Override
public void setElement(IAdaptable element) {
fElement = element;
if (element instanceof ICBreakpoint) {
fElement = new CBreakpointContext((ICBreakpoint)element, null);
}
else {
fElement = element;
}
}
protected String[] getDebugModelIds() {

7
dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/breakpoints/GDBTracepointPropertyPage.java
View file

@ -476,7 +476,12 @@ public class GDBTracepointPropertyPage extends FieldEditorPreferencePage impleme
*/
@Override
public void setElement(IAdaptable element) {
fElement = element;
if (element instanceof ICBreakpoint) {
fElement = new CBreakpointContext((ICBreakpoint)element, null);
}
else {
fElement = element;
}
}
protected String[] getDebugModelIds() {