mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-09 10:05:24 +02:00
Code Issues Wiki Activity

[166156] don't call disconnect on disconnected subsystems during delete - since it causes lots of unnnecssary events

Browse source
This commit is contained in:
David McKnight 2006-12-01 17:18:44 +00:00
parent c1c163702a
commit 166f85cb21
1 changed files with 16 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java
View file

@ -932,6 +932,8 @@ public abstract class SubSystemConfiguration implements ISubSystemConfiguration
//System.out.println("in deleteSubSystemsByConnection. Nbr subsystems = " + subsystems.length); //System.out.println("in deleteSubSystemsByConnection. Nbr subsystems = " + subsystems.length);
for (int idx = 0; idx < subsystems.length; idx++) for (int idx = 0; idx < subsystems.length; idx++)
{
if (subsystems[idx].isConnected())
{ {
try try
{ {
@ -940,6 +942,7 @@ public abstract class SubSystemConfiguration implements ISubSystemConfiguration
catch (Exception exc) catch (Exception exc)
{ {
} }
}
subsystems[idx].deletingConnection(); // let subsystem do any clean up needed prior to death subsystems[idx].deletingConnection(); // let subsystem do any clean up needed prior to death
deleteSubSystem(subsystems[idx]); deleteSubSystem(subsystems[idx]);
} }
@ -1589,6 +1592,8 @@ public abstract class SubSystemConfiguration implements ISubSystemConfiguration
* Handled for you! * Handled for you!
*/ */
public boolean deleteSubSystem(ISubSystem subsystem) public boolean deleteSubSystem(ISubSystem subsystem)
{
if (subsystem.isConnected())
{ {
try try
{ {
@ -1597,6 +1602,7 @@ public abstract class SubSystemConfiguration implements ISubSystemConfiguration
catch (Exception exc) catch (Exception exc)
{ {
} }
}
removeSubSystem(subsystem); // remove from our in-memory cache removeSubSystem(subsystem); // remove from our in-memory cache
ISystemFilterPoolReferenceManager fpRefMgr = subsystem.getSystemFilterPoolReferenceManager(); ISystemFilterPoolReferenceManager fpRefMgr = subsystem.getSystemFilterPoolReferenceManager();
if (fpRefMgr != null) if (fpRefMgr != null)