mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-20 07:25:23 +02:00
Code Issues Wiki Activity

Fixes for Bug234314 and Bug234289

Browse source
This commit is contained in:
Francois Chouinard 2008-05-28 13:40:49 +00:00
parent df5a3a60e0
commit 1720457ddb
3 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
plugins/org.eclipse.dd.dsf.debug/src/org/eclipse/dd/dsf/debug/model/DsfMemoryBlock.java
View file

@ -472,6 +472,15 @@ public class DsfMemoryBlock extends PlatformObject implements IMemoryBlockExtens
drm.setData(getData()); drm.setData(getData());
drm.done(); drm.done();
} }
@Override
protected void handleFailure() {
// Bug234289: If memory read fails, return a block marked as invalid
MemoryByte[] block = new MemoryByte[fWordSize * (int) length];
for (int i = 0; i < block.length; i++)
block[i] = new MemoryByte((byte) 0, (byte) 0);
drm.setData(block);
drm.done();
}
}); });
} }

2
plugins/org.eclipse.dd.dsf/src/org/eclipse/dd/dsf/concurrent/CountingRequestMonitor.java
View file

@ -49,7 +49,7 @@ public class CountingRequestMonitor extends RequestMonitor {
public CountingRequestMonitor(Executor executor, RequestMonitor parentRequestMonitor) { public CountingRequestMonitor(Executor executor, RequestMonitor parentRequestMonitor) {
super(executor, parentRequestMonitor); super(executor, parentRequestMonitor);
setStatus(new MultiStatus(DsfPlugin.PLUGIN_ID, 0, "Collective status for set of sub-operations.", null)); //$NON-NLS-1$ super.setStatus(new MultiStatus(DsfPlugin.PLUGIN_ID, 0, "Collective status for set of sub-operations.", null)); //$NON-NLS-1$
} }
/** /**

8
plugins/org.eclipse.dd.mi/src/org/eclipse/dd/mi/service/MIMemory.java
View file

@ -877,13 +877,7 @@ public class MIMemory extends AbstractDsfService implements IMemory {
{ {
// Each byte is written individually (GDB power...) // Each byte is written individually (GDB power...)
// so we need to keep track of the count // so we need to keep track of the count
final CountingRequestMonitor countingRM = final CountingRequestMonitor countingRM = new CountingRequestMonitor(getExecutor(), rm);
new CountingRequestMonitor(getExecutor(), rm) {
@Override
protected void handleSuccess() {
rm.done();
}
};
countingRM.setDoneCount(count); countingRM.setDoneCount(count);
// We will format the individual bytes in decimal // We will format the individual bytes in decimal