mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

Bug 573677: Mark methods that don't handle commands well as deprecated

Browse source 
Some of these commands work "by accident" on Windows, but there are lots
of special/corner cases that may not. On Linux they almost certainly
never do the correct thing when spaces are in arguments.

(follow up for 1557c2c4f5)

Change-Id: I126d60423b0e4ff6d9d240d7de2c1a4905763415
This commit is contained in:
Jonah Graham 2021-06-14 15:37:36 -04:00
parent a6e6be0457
commit 1ac907184b
3 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/org.eclipse.cdt.core.native/META-INF/MANIFEST.MF
View file

@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.cdt.core.native;singleton:=true
Bundle-Version: 6.1.200.qualifier
Bundle-Version: 6.1.300.qualifier
Bundle-Activator: org.eclipse.cdt.internal.core.natives.CNativePlugin
Bundle-Vendor: %providerName
Bundle-Localization: plugin

2
core/org.eclipse.cdt.core.native/pom.xml
View file

@ -23,7 +23,7 @@
<relativePath>../../pom.xml</relativePath>
</parent>
<version>6.1.200-SNAPSHOT</version>
<version>6.1.300-SNAPSHOT</version>
<artifactId>org.eclipse.cdt.core.native</artifactId>
<packaging>eclipse-plugin</packaging>

12
core/org.eclipse.cdt.core.native/src/org/eclipse/cdt/utils/spawner/ProcessFactory.java
View file

@ -58,6 +58,10 @@ public class ProcessFactory {
return instance;
}
/**
* @deprecated Do not use this method it splits command line arguments on whitespace with no regard to quoting rules. See Bug 573677
*/
@Deprecated
public Process exec(String cmd) throws IOException {
cmd = modifyCmdIfFlatpak(cmd);
if (hasSpawner)
@ -79,6 +83,10 @@ public class ProcessFactory {
return runtime.exec(cmdarray, envp);
}
/**
* @deprecated Do not use this method it splits command line arguments on whitespace with no regard to quoting rules. See Bug 573677
*/
@Deprecated
public Process exec(String cmd, String[] envp) throws IOException {
cmd = modifyCmdIfFlatpak(cmd);
if (hasSpawner)
@ -86,6 +94,10 @@ public class ProcessFactory {
return runtime.exec(cmd, envp);
}
/**
* @deprecated Do not use this method it splits command line arguments on whitespace with no regard to quoting rules. See Bug 573677
*/
@Deprecated
public Process exec(String cmd, String[] envp, File dir) throws IOException {
cmd = modifyCmdIfFlatpak(cmd);
if (hasSpawner)