From 1b155ec4eb99d3e68e298c53f20fe3adec313ea6 Mon Sep 17 00:00:00 2001 From: Greg Watson Date: Mon, 11 Jan 2016 09:00:19 -0500 Subject: [PATCH] Bug 485549 - prevent ArrayIndexOutOfBoundsException if no services are installed. Change-Id: I96249643103ea9427b1c5d165d8854e50984f614 Signed-off-by: Greg Watson --- .../preferences/ConnectionsPreferencePage.java | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/bundles/org.eclipse.remote.ui/src/org/eclipse/remote/internal/ui/preferences/ConnectionsPreferencePage.java b/bundles/org.eclipse.remote.ui/src/org/eclipse/remote/internal/ui/preferences/ConnectionsPreferencePage.java index 8cb7e0d10f3..fe7369b1575 100644 --- a/bundles/org.eclipse.remote.ui/src/org/eclipse/remote/internal/ui/preferences/ConnectionsPreferencePage.java +++ b/bundles/org.eclipse.remote.ui/src/org/eclipse/remote/internal/ui/preferences/ConnectionsPreferencePage.java @@ -386,16 +386,18 @@ public class ConnectionsPreferencePage extends PreferencePage implements IWorkbe fCloseButton.addSelectionListener(fEventHandler); fCloseButton.setEnabled(false); - String id = Preferences.getString(IRemotePreferenceConstants.PREF_CONNECTION_TYPE_ID); - if ("".equals(id)) { //$NON-NLS-1$ - id = fServiceIDs[0]; - } - for (int i = 0; i < fServiceIDs.length; i++) { - if (id.equals(fServiceIDs[i])) { - fServicesCombo.select(i); + if (fServiceIDs.length > 0) { + String id = Preferences.getString(IRemotePreferenceConstants.PREF_CONNECTION_TYPE_ID); + if ("".equals(id)) { //$NON-NLS-1$ + id = fServiceIDs[0]; } + for (int i = 0; i < fServiceIDs.length; i++) { + if (id.equals(fServiceIDs[i])) { + fServicesCombo.select(i); + } + } + selectServices(id); } - selectServices(id); return preferencePane; }