mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

Bug 303808: Disable full console in all-stop mode for the moment

Browse source 
We currently cannot interrupt execution with the new console in all-stop
mode. This means that if the user resumes execution then no new
breakpoints can be set from CDT while the target is running; also, the
interrupt button simply does not work.

This patch temporarily disables the new console in all-stop, until we
have the problem fixed.

This also solves the pagination problem as pagination is only enabled
in all-stop mode.

Change-Id: I858268d469923700ae960600cb1dbb062729dc88
This commit is contained in:
Marc Khouzam 2016-08-24 10:13:29 -04:00
parent e9b297390b
commit 2388bb65c5
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBBackend_7_12.java
View file

@ -14,6 +14,7 @@ import java.io.OutputStream;
import org.eclipse.cdt.core.parser.util.StringUtil; import org.eclipse.cdt.core.parser.util.StringUtil;
import org.eclipse.cdt.dsf.gdb.internal.GdbPlugin; import org.eclipse.cdt.dsf.gdb.internal.GdbPlugin;
import org.eclipse.cdt.dsf.gdb.launching.LaunchUtils;
import org.eclipse.cdt.dsf.service.DsfSession; import org.eclipse.cdt.dsf.service.DsfSession;
import org.eclipse.cdt.utils.pty.PTY; import org.eclipse.cdt.utils.pty.PTY;
import org.eclipse.cdt.utils.pty.PTY.Mode; import org.eclipse.cdt.utils.pty.PTY.Mode;
@ -44,16 +45,20 @@ public class GDBBackend_7_12 extends GDBBackend {
/** Indicate that we failed to create a PTY. */ /** Indicate that we failed to create a PTY. */
private boolean fPtyFailure; private boolean fPtyFailure;
private boolean fIsAllStop;
private InputStream fDummyErrorStream; private InputStream fDummyErrorStream;
public GDBBackend_7_12(DsfSession session, ILaunchConfiguration lc) { public GDBBackend_7_12(DsfSession session, ILaunchConfiguration lc) {
super(session, lc); super(session, lc);
fIsAllStop = !LaunchUtils.getIsNonStopMode(lc);
createPty(); createPty();
} }
@Override @Override
public boolean isFullGdbConsoleSupported() { public boolean isFullGdbConsoleSupported() {
return !Platform.getOS().equals(Platform.OS_WIN32) return !Platform.getOS().equals(Platform.OS_WIN32)
&& !fIsAllStop
&& !fPtyFailure; && !fPtyFailure;
} }