mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-26 10:25:32 +02:00
Code Issues Wiki Activity

[404082][dstore] race condition on finish, removing senders

Browse source
This commit is contained in:
David McKnight 2013-03-22 08:49:43 -04:00
parent e8100d2429
commit 251a5a5a44
1 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
rse/plugins/org.eclipse.dstore.core/src/org/eclipse/dstore/internal/core/server/ServerUpdateHandler.java
View file

@ -1,5 +1,5 @@
/******************************************************************************* /*******************************************************************************
* Copyright (c) 2002, 2012 IBM Corporation and others. * Copyright (c) 2002, 2013 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials * All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0 * are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at * which accompanies this distribution, and is available at
@ -17,6 +17,7 @@
* David McKnight (IBM) [246826][dstore] KeepAlive does not work correctly * David McKnight (IBM) [246826][dstore] KeepAlive does not work correctly
* David McKnight (IBM) - [358301] [DSTORE] Hang during debug source look up * David McKnight (IBM) - [358301] [DSTORE] Hang during debug source look up
* David McKnight (IBM) [388873][dstore] ServerUpdateHandler _senders list should be synchronized * David McKnight (IBM) [388873][dstore] ServerUpdateHandler _senders list should be synchronized
* David McKnight (IBM) [404082][dstore] race condition on finish, removing senders
*******************************************************************************/ *******************************************************************************/
package org.eclipse.dstore.internal.core.server; package org.eclipse.dstore.internal.core.server;
@ -352,17 +353,15 @@ public class ServerUpdateHandler extends UpdateHandler
*/ */
public void removeSenderWith(Socket socket) public void removeSenderWith(Socket socket)
{ {
synchronized (_senders){ for (int i = 0; i < _senders.size(); i++)
for (int i = 0; i < _senders.size(); i++) {
Sender sender = (Sender) _senders.get(i);
if (sender.socket() == socket)
{ {
Sender sender = (Sender) _senders.get(i); // sender sends last ack before death
if (sender.socket() == socket) DataElement document = _dataStore.createObject(null, DataStoreResources.DOCUMENT_TYPE, "exit", "exit"); //$NON-NLS-1$ //$NON-NLS-2$
{ sender.sendDocument(document, 2);
// sender sends last ack before death removeSender(sender);
DataElement document = _dataStore.createObject(null, DataStoreResources.DOCUMENT_TYPE, "exit", "exit"); //$NON-NLS-1$ //$NON-NLS-2$
sender.sendDocument(document, 2);
removeSender(sender);
}
} }
} }
} }