mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-11 02:05:39 +02:00
Code Issues Wiki Activity

Fix for GDB 13 "script" field in breakpoint

Browse source 
"script" field of a breakpoint used to be output as a tuple (<= GDB 12),
though it is a list. There are cases of flags that can be applied to
get old or new behaviour too.
This code handles both cases transparently.
See https://sourceware.org/bugzilla/show_bug.cgi?id=24285

Part of #816
This commit is contained in:
Jonah Graham 2025-01-21 12:47:33 -05:00
parent 259fb0f99d
commit 3594dce68a
1 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/output/MIBreakpoint.java
View file

@ -626,8 +626,8 @@ public class MIBreakpoint {
// Only supported starting with GDB 6.8 // Only supported starting with GDB 6.8
pending = true; pending = true;
} else if (var.equals("script")) { //$NON-NLS-1$ } else if (var.equals("script")) { //$NON-NLS-1$
if (value instanceof MITuple) { if (value instanceof MITuple || value instanceof MIList) {
parseCommands((MITuple) value); parseCommands(value);
} }
} else if (var.equals("thread-groups")) { //$NON-NLS-1$ } else if (var.equals("thread-groups")) { //$NON-NLS-1$
if (value instanceof MIList) { if (value instanceof MIList) {
@ -639,8 +639,20 @@ public class MIBreakpoint {
} }
} }
void parseCommands(MITuple tuple) { void parseCommands(MIValue miValue) {
MIValue[] values = tuple.getMIValues(); // "script" field of a breakpoint used to be output as a tuple (<= GDB 12),
// though it is a list. There are cases of flags that can be applied to
// get old or new behaviour too.
// This code handles both cases transparently.
// See https://sourceware.org/bugzilla/show_bug.cgi?id=24285
MIValue[] values;
if (miValue instanceof MITuple tuple) {
values = tuple.getMIValues();
} else if (miValue instanceof MIList list) {
values = list.getMIValues();
} else {
throw new IllegalStateException("miValue must be tuple or list"); //$NON-NLS-1$
}
StringBuilder cmds = new StringBuilder(); StringBuilder cmds = new StringBuilder();
for (int i = 0; i < values.length; i++) { for (int i = 0; i < values.length; i++) {
MIValue value = values[i]; MIValue value = values[i];