mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-21 07:55:24 +02:00
Code Issues Wiki Activity

Trivialize the leak caused by bugzilla 255120 (debug platform) by clearing the reference to CDebugTarget in the dispose() method.

Browse source
This commit is contained in:
John Cortell 2008-11-17 16:06:47 +00:00
parent ce938eda30
commit 3d48bf4f02
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/CMemoryBlockRetrievalExtension.java
View file

@ -189,7 +189,7 @@ public class CMemoryBlockRetrievalExtension extends PlatformObject implements IM
BigInteger addrBigInt = null; BigInteger addrBigInt = null;
String memorySpaceID = null; String memorySpaceID = null;
if (hasMemorySpaces()) { if (hasMemorySpaces() && fDebugTarget != null) {
// Can't tell if block was created with a memory-space/address or with an expression. // Can't tell if block was created with a memory-space/address or with an expression.
// Assume the former and let an exception in the decoding tell us otherwise // Assume the former and let an exception in the decoding tell us otherwise
ICDITarget cdiTarget = fDebugTarget.getCDITarget(); ICDITarget cdiTarget = fDebugTarget.getCDITarget();
@ -392,6 +392,8 @@ public class CMemoryBlockRetrievalExtension extends PlatformObject implements IM
} }
public void dispose() { public void dispose() {
// Minimize leaks. See bugzilla 255120
fDebugTarget = null;
} }
/** /**
@ -410,9 +412,11 @@ public class CMemoryBlockRetrievalExtension extends PlatformObject implements IM
* @return an array of memory space identifiers * @return an array of memory space identifiers
*/ */
public String [] getMemorySpaces() { public String [] getMemorySpaces() {
if (fDebugTarget != null) {
ICDITarget cdiTarget = fDebugTarget.getCDITarget(); ICDITarget cdiTarget = fDebugTarget.getCDITarget();
if (cdiTarget instanceof ICDIMemorySpaceManagement) if (cdiTarget instanceof ICDIMemorySpaceManagement)
return ((ICDIMemorySpaceManagement)cdiTarget).getMemorySpaces(); return ((ICDIMemorySpaceManagement)cdiTarget).getMemorySpaces();
}
return new String[0]; return new String[0];
} }