mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

Dispose font in TerminalColorsFieldEditor

Browse source 
TerminalColorsFieldEditor had a dispose method, but
FieldEditorPreferencePage does not call dispose on the
individual field editors despite API implication that
it should.

Change-Id: I98c2987446d8b005cbca571763a9e811e966e0d3
This commit is contained in:
Jonah Graham 2022-02-25 11:26:49 -05:00
parent 4c87198224
commit 45237eed0b
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/preferences/TerminalPreferencePage.java
View file

@ -37,6 +37,8 @@ import org.eclipse.ui.IWorkbenchPreferencePage;
*/
public class TerminalPreferencePage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage {
private TerminalColorsFieldEditor terminalColorsFieldEditor;
public TerminalPreferencePage() {
super(GRID);
}
@ -72,6 +74,16 @@ public class TerminalPreferencePage extends FieldEditorPreferencePage implements
addField(new IntegerFieldEditor(ITerminalConstants.PREF_BUFFERLINES, TerminalMessages.BUFFERLINES,
getFieldEditorParent()));
addField(new TerminalColorsFieldEditor(getFieldEditorParent()));
terminalColorsFieldEditor = new TerminalColorsFieldEditor(getFieldEditorParent());
addField(terminalColorsFieldEditor);
}
@Override
public void dispose() {
if (terminalColorsFieldEditor != null) {
terminalColorsFieldEditor.dispose();
}
super.dispose();
}
}