From 45237eed0bb93c42d6b4ccf201f3cc665d5d3a9a Mon Sep 17 00:00:00 2001 From: Jonah Graham Date: Fri, 25 Feb 2022 11:26:49 -0500 Subject: [PATCH] Dispose font in TerminalColorsFieldEditor TerminalColorsFieldEditor had a dispose method, but FieldEditorPreferencePage does not call dispose on the individual field editors despite API implication that it should. Change-Id: I98c2987446d8b005cbca571763a9e811e966e0d3 --- .../preferences/TerminalPreferencePage.java | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/preferences/TerminalPreferencePage.java b/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/preferences/TerminalPreferencePage.java index 6dcc77da03f..27888302669 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/preferences/TerminalPreferencePage.java +++ b/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/preferences/TerminalPreferencePage.java @@ -37,6 +37,8 @@ import org.eclipse.ui.IWorkbenchPreferencePage; */ public class TerminalPreferencePage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage { + private TerminalColorsFieldEditor terminalColorsFieldEditor; + public TerminalPreferencePage() { super(GRID); } @@ -72,6 +74,16 @@ public class TerminalPreferencePage extends FieldEditorPreferencePage implements addField(new IntegerFieldEditor(ITerminalConstants.PREF_BUFFERLINES, TerminalMessages.BUFFERLINES, getFieldEditorParent())); - addField(new TerminalColorsFieldEditor(getFieldEditorParent())); + terminalColorsFieldEditor = new TerminalColorsFieldEditor(getFieldEditorParent()); + addField(terminalColorsFieldEditor); + } + + @Override + public void dispose() { + if (terminalColorsFieldEditor != null) { + terminalColorsFieldEditor.dispose(); + } + + super.dispose(); } }