From 49a9b0c3f6939e79278ed71bd1e4b8cd7620eb8d Mon Sep 17 00:00:00 2001 From: Sergey Prigogin Date: Mon, 16 Nov 2015 20:12:51 -0800 Subject: [PATCH] Cosmetics. --- .../tests/ast2/CompleteParser2Tests.java | 22 +++++++++---------- .../core/dom/ast/IASTInitializerClause.java | 1 + .../POPCPPParserExtensionConfiguration.java | 1 + 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/CompleteParser2Tests.java b/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/CompleteParser2Tests.java index d5755976da3..965037919ab 100644 --- a/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/CompleteParser2Tests.java +++ b/core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/CompleteParser2Tests.java @@ -17,8 +17,6 @@ import java.io.Writer; import java.util.ArrayList; import java.util.List; -import junit.framework.TestSuite; - import org.eclipse.cdt.core.dom.ast.ASTVisitor; import org.eclipse.cdt.core.dom.ast.IASTCompositeTypeSpecifier; import org.eclipse.cdt.core.dom.ast.IASTCompoundStatement; @@ -84,6 +82,8 @@ import org.eclipse.cdt.internal.core.dom.parser.cpp.GNUCPPSourceParser; import org.eclipse.cdt.internal.core.dom.parser.cpp.semantics.CPPVisitor; import org.eclipse.cdt.internal.core.parser.ParserException; +import junit.framework.TestSuite; + /** * @author jcamelon */ @@ -1172,7 +1172,7 @@ public class CompleteParser2Tests extends BaseTestCase { } public void testBug43503() throws Exception { - StringBuffer buff = new StringBuffer(); + StringBuilder buff = new StringBuilder(); buff.append("class SD_02 { "); buff.append(" public: "); @@ -1276,7 +1276,7 @@ public class CompleteParser2Tests extends BaseTestCase { } public void testCDesignatedInitializers() throws Exception { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("struct Inner { int a,b,c; };"); buffer.append("struct A { int x; int y[]; struct Inner innerArray[]; int z[]; };"); buffer.append("struct A myA = { .x = 4, .y[3] = 4, .y[4] = 3, .innerArray[0].a = 3, .innerArray[1].b = 5, .innerArray[2].c=6, .z = { 1,4,5} };"); @@ -1325,7 +1325,7 @@ public class CompleteParser2Tests extends BaseTestCase { } public void testBug44925() throws Exception { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("class MyClass { };"); buffer.append("class MyClass myObj1;"); buffer.append("enum MyEnum { Item1 };"); @@ -1350,7 +1350,7 @@ public class CompleteParser2Tests extends BaseTestCase { } public void testBug44838() throws Exception { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("class A { int myX; A(int x); };\n"); buffer.append("A::A(int x) : myX(x) { if (x == 5) myX++; }\n"); IASTTranslationUnit tu = parse(buffer.toString()); @@ -1371,14 +1371,14 @@ public class CompleteParser2Tests extends BaseTestCase { } public void testBug46165() throws Exception { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("class A { int myX; A(int x); };\n"); buffer.append("A::A(int x) : myX(x) { if (x == 5) myX++; }\n"); parse(buffer.toString()); } public void testBug47624() throws Exception { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("struct s { }; \n"); buffer.append("void f (int s) { \n"); buffer.append(" struct s sInstance; \n"); @@ -1401,7 +1401,7 @@ public class CompleteParser2Tests extends BaseTestCase { public void testQualifiedLookup() throws Exception { //this is meant to test that on a->f, the lookup for f is qualified //the namespace is necessary because of bug 47926 - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("namespace N {"); buffer.append(" void f () {} \n"); buffer.append(" class A { }; \n"); @@ -1429,7 +1429,7 @@ public class CompleteParser2Tests extends BaseTestCase { } public void testBug43110() throws Exception { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("void x(int y, ...);\n"); buffer.append("void y(int x...);\n"); buffer.append("void z(...);"); @@ -1448,7 +1448,7 @@ public class CompleteParser2Tests extends BaseTestCase { } public void testBug43110_XRef() throws Exception { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("void foo(...) {}\n"); buffer.append("void main(){ foo(1); }\n"); diff --git a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/IASTInitializerClause.java b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/IASTInitializerClause.java index ae623bf7cf4..24bf0b12d51 100644 --- a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/IASTInitializerClause.java +++ b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/ast/IASTInitializerClause.java @@ -13,6 +13,7 @@ package org.eclipse.cdt.core.dom.ast; /** * Interface for AST nodes that can nest in initializer lists. * @since 5.2 + * * @noextend This interface is not intended to be extended by clients. * @noimplement This interface is not intended to be implemented by clients. */ diff --git a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/parser/cpp/POPCPPParserExtensionConfiguration.java b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/parser/cpp/POPCPPParserExtensionConfiguration.java index 840331fe2d8..1f29d75e194 100644 --- a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/parser/cpp/POPCPPParserExtensionConfiguration.java +++ b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/core/dom/parser/cpp/POPCPPParserExtensionConfiguration.java @@ -17,6 +17,7 @@ package org.eclipse.cdt.core.dom.parser.cpp; */ public class POPCPPParserExtensionConfiguration extends GPPParserExtensionConfiguration { private static POPCPPParserExtensionConfiguration sInstance= new POPCPPParserExtensionConfiguration(); + public static POPCPPParserExtensionConfiguration getInstance() { return sInstance; }