mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-09 10:05:24 +02:00
Code Issues Wiki Activity

[180562] [api] Classes should not implement interfaces just to bring constants into namespace. Do not implement IHostSearchConstants.

Browse source
This commit is contained in:
Kushal Munir 2007-04-03 08:25:42 +00:00
parent 256766d3ad
commit 4f31956e59
5 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
rse/plugins/org.eclipse.rse.services/src/org/eclipse/rse/services/search/AbstractSearchResultConfiguration.java
View file

@ -55,7 +55,7 @@ public abstract class AbstractSearchResultConfiguration implements IHostSearchRe
setParentResultSet(resultSet); setParentResultSet(resultSet);
setSearchTarget(searchObject); setSearchTarget(searchObject);
setSearchString(string); setSearchString(string);
setStatus(RUNNING); setStatus(IHostSearchConstants.RUNNING);
_searchService = searchService; _searchService = searchService;
_containedResults = new HashMap(); _containedResults = new HashMap();
} }
@ -184,7 +184,7 @@ public abstract class AbstractSearchResultConfiguration implements IHostSearchRe
public void cancel() { public void cancel() {
// if not running, return // if not running, return
if (getStatus() != RUNNING) { if (getStatus() != IHostSearchConstants.RUNNING) {
return; return;
} }
} }

2
rse/plugins/org.eclipse.rse.services/src/org/eclipse/rse/services/search/IHostSearchResultConfiguration.java
View file

@ -21,7 +21,7 @@ import org.eclipse.rse.services.clientserver.SystemSearchString;
/** /**
* An interface representing a search result configuration. * An interface representing a search result configuration.
*/ */
public interface IHostSearchResultConfiguration extends IHostSearchConstants { public interface IHostSearchResultConfiguration {
/** /**
* Sets the parent result set. * Sets the parent result set.

7
rse/plugins/org.eclipse.rse.subsystems.files.core/src/org/eclipse/rse/subsystems/files/core/subsystems/RemoteSearchResultConfiguration.java
View file

@ -21,6 +21,7 @@ import java.util.Map;
import java.util.Vector; import java.util.Vector;
import org.eclipse.rse.services.clientserver.SystemSearchString; import org.eclipse.rse.services.clientserver.SystemSearchString;
import org.eclipse.rse.services.search.IHostSearchConstants;
import org.eclipse.rse.services.search.IHostSearchResult; import org.eclipse.rse.services.search.IHostSearchResult;
import org.eclipse.rse.services.search.IHostSearchResultConfiguration; import org.eclipse.rse.services.search.IHostSearchResultConfiguration;
import org.eclipse.rse.services.search.IHostSearchResultSet; import org.eclipse.rse.services.search.IHostSearchResultSet;
@ -48,14 +49,14 @@ public class RemoteSearchResultConfiguration implements IHostSearchResultConfigu
* Constructor for a result set configuration. Sets status to <code>RUNNING</code>. * Constructor for a result set configuration. Sets status to <code>RUNNING</code>.
* @param resultSet the parent result set. * @param resultSet the parent result set.
* @param searchObject the target of the search. * @param searchObject the target of the search.
* @param searchString the search string. * @param string the search string.
*/ */
public RemoteSearchResultConfiguration(IHostSearchResultSet resultSet, Object searchObject, SystemSearchString string) { public RemoteSearchResultConfiguration(IHostSearchResultSet resultSet, Object searchObject, SystemSearchString string) {
results = new Vector(); results = new Vector();
setParentResultSet(resultSet); setParentResultSet(resultSet);
setSearchTarget(searchObject); setSearchTarget(searchObject);
setSearchString(string); setSearchString(string);
setStatus(RUNNING); setStatus(IHostSearchConstants.RUNNING);
_containedResults = new HashMap(); _containedResults = new HashMap();
} }
@ -170,7 +171,7 @@ public class RemoteSearchResultConfiguration implements IHostSearchResultConfigu
public void cancel() { public void cancel() {
// if not running, return // if not running, return
if (getStatus() != RUNNING) { if (getStatus() != IHostSearchConstants.RUNNING) {
return; return;
} }
} }

3
rse/plugins/org.eclipse.rse.subsystems.files.dstore/src/org/eclipse/rse/internal/subsystems/files/dstore/DStoreFileSubSystemSearchResultConfiguration.java
View file

@ -24,6 +24,7 @@ import org.eclipse.dstore.extra.DomainEvent;
import org.eclipse.rse.core.subsystems.RemoteChildrenContentsType; import org.eclipse.rse.core.subsystems.RemoteChildrenContentsType;
import org.eclipse.rse.internal.services.dstore.search.DStoreSearchResultConfiguration; import org.eclipse.rse.internal.services.dstore.search.DStoreSearchResultConfiguration;
import org.eclipse.rse.services.clientserver.SystemSearchString; import org.eclipse.rse.services.clientserver.SystemSearchString;
import org.eclipse.rse.services.search.IHostSearchConstants;
import org.eclipse.rse.services.search.IHostSearchResult; import org.eclipse.rse.services.search.IHostSearchResult;
import org.eclipse.rse.services.search.IHostSearchResultSet; import org.eclipse.rse.services.search.IHostSearchResultSet;
import org.eclipse.rse.services.search.ISearchService; import org.eclipse.rse.services.search.ISearchService;
@ -131,7 +132,7 @@ public class DStoreFileSubSystemSearchResultConfiguration extends DStoreSearchRe
{ {
if (_status.getValue().equals("done")) //$NON-NLS-1$ if (_status.getValue().equals("done")) //$NON-NLS-1$
{ {
setStatus(FINISHED); setStatus(IHostSearchConstants.FINISHED);
_status.getDataStore().getDomainNotifier().removeDomainListener(this); _status.getDataStore().getDomainNotifier().removeDomainListener(this);
} }

3
rse/plugins/org.eclipse.rse.subsystems.files.local/src/org/eclipse/rse/internal/subsystems/files/local/LocalSearchResultConfiguration.java
View file

@ -20,6 +20,7 @@ package org.eclipse.rse.internal.subsystems.files.local;
import org.eclipse.rse.services.clientserver.SystemSearchString; import org.eclipse.rse.services.clientserver.SystemSearchString;
import org.eclipse.rse.services.files.IHostFile; import org.eclipse.rse.services.files.IHostFile;
import org.eclipse.rse.services.search.AbstractSearchResultConfiguration; import org.eclipse.rse.services.search.AbstractSearchResultConfiguration;
import org.eclipse.rse.services.search.IHostSearchConstants;
import org.eclipse.rse.services.search.IHostSearchResult; import org.eclipse.rse.services.search.IHostSearchResult;
import org.eclipse.rse.services.search.IHostSearchResultSet; import org.eclipse.rse.services.search.IHostSearchResultSet;
import org.eclipse.rse.services.search.ISearchService; import org.eclipse.rse.services.search.ISearchService;
@ -91,7 +92,7 @@ public class LocalSearchResultConfiguration extends AbstractSearchResultConfigur
public void cancel() { public void cancel() {
// if not running, call super // if not running, call super
if (getStatus() != RUNNING) { if (getStatus() != IHostSearchConstants.RUNNING) {
super.cancel(); super.cancel();
return; return;
} }