mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-31 21:05:37 +02:00
Code Issues Wiki Activity

Bug 342239 - Traditional memory rendering lacks per byte display granularity for unreadable bytes

Browse source
This commit is contained in:
Teodor Madan 2011-04-08 13:59:12 +00:00
parent 8ac1692a9e
commit 60417d5ce5
1 changed files with 25 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
memory/org.eclipse.cdt.debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/Rendering.java
View file

@ -1943,12 +1943,19 @@ public class Rendering extends Composite implements IDebugEventSetListener
public String getRadixText(MemoryByte bytes[], int radix, public String getRadixText(MemoryByte bytes[], int radix,
boolean isLittleEndian) boolean isLittleEndian)
{ {
boolean readable = true; boolean readableByte = false;
for(int i = 0; i < bytes.length; i++) boolean allBytesReadable = true;
if(!bytes[i].isReadable()) for(int i = 0; i < bytes.length; i++) {
readable = false; if(!bytes[i].isReadable()) {
allBytesReadable = false;
} else {
readableByte = true;
}
}
if(readable) // convert byte to character if all bytes are readable or
// it is a mixed of readable&non-readable bytes and format is Hex or Binary. Bugzilla 342239
if (allBytesReadable || readableByte && (radix == Rendering.RADIX_HEX || radix == Rendering.RADIX_BINARY))
{ {
// bytes from the cache are stored as a sequential byte sequence regardless of target endian. // bytes from the cache are stored as a sequential byte sequence regardless of target endian.
// the endian attribute tells us the recommended endian for display. the user may change this // the endian attribute tells us the recommended endian for display. the user may change this
@ -1991,8 +1998,13 @@ public class Rendering extends Composite implements IDebugEventSetListener
{ {
for(int i = buf.length - 1; i >= 0; i--) for(int i = buf.length - 1; i >= 0; i--)
{ {
buf[i] = hexdigits[(int) (value & 1)]; int byteIndex = needsSwap ? bytes.length - 1 - i/8 : i/8;
value = value >>> 1; if (bytes[byteIndex].isReadable()) {
buf[i] = hexdigits[(int) (value & 1)];
} else {
buf[i] = getPaddingCharacter();
}
value = value >>> 1;
} }
break; break;
} }
@ -2009,7 +2021,12 @@ public class Rendering extends Composite implements IDebugEventSetListener
{ {
for(int i = buf.length - 1; i >= 0; i--) for(int i = buf.length - 1; i >= 0; i--)
{ {
buf[i] = hexdigits[(int) (value & 15)]; int byteIndex = needsSwap ? bytes.length - 1 - i/2 : i/2;
if (bytes[byteIndex].isReadable()) {
buf[i] = hexdigits[(int) (value & 15)];
} else {
buf[i] = getPaddingCharacter();
}
value = value >>> 4; value = value >>> 4;
} }
break; break;