mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-26 18:35:32 +02:00
Code Issues Wiki Activity

bug 150949 - Removed the public "debug" setting. It can now only be used when in a development environment. It generates far too many messages to be useful in a production setting.

Browse source
This commit is contained in:
David Dykstal 2006-09-14 22:14:21 +00:00
parent cede258b82
commit 68d8ec8366
2 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
rse/plugins/org.eclipse.rse.logging/src/org/eclipse/rse/logging/Logger.java
View file

@ -72,6 +72,15 @@ import org.eclipse.core.runtime.Preferences.PropertyChangeEvent;
*/ */
public class Logger implements IPropertyChangeListener { public class Logger implements IPropertyChangeListener {
/**
* Constant can be used to surround debugging code. Optimizing
* compilers have the possibility of removing the code from
* a production copy.
*
* Should be set false normally. Only set to true when testing.
*/
public static final boolean DEBUG = false;
private ILog systemsPluginLog = null; private ILog systemsPluginLog = null;
private RemoteSystemLogListener logListener = null; private RemoteSystemLogListener logListener = null;
private String pluginId = null; private String pluginId = null;
@ -121,7 +130,7 @@ public class Logger implements IPropertyChangeListener {
* need to be localized to proper local.<br> * need to be localized to proper local.<br>
*/ */
public synchronized void logDebugMessage(String className, String message) { public synchronized void logDebugMessage(String className, String message) {
if (debug_level >= IRemoteSystemsLogging.LOG_DEBUG) { if (Logger.DEBUG && debug_level >= IRemoteSystemsLogging.LOG_DEBUG) {
MultiStatus debugStatus = new MultiStatus(pluginId, IStatus.OK, className, null); MultiStatus debugStatus = new MultiStatus(pluginId, IStatus.OK, className, null);
Status infoStatus = new Status(IStatus.OK, pluginId, IStatus.OK, message, null); Status infoStatus = new Status(IStatus.OK, pluginId, IStatus.OK, message, null);
debugStatus.add(infoStatus); debugStatus.add(infoStatus);

7
rse/plugins/org.eclipse.rse.logging/src/org/eclipse/rse/logging/ui/LoggingPreferencePage.java
View file

@ -25,6 +25,7 @@ import org.eclipse.jface.preference.IPreferenceStore;
import org.eclipse.jface.preference.PreferencePage; import org.eclipse.jface.preference.PreferencePage;
import org.eclipse.jface.preference.PreferenceStore; import org.eclipse.jface.preference.PreferenceStore;
import org.eclipse.rse.logging.IRemoteSystemsLogging; import org.eclipse.rse.logging.IRemoteSystemsLogging;
import org.eclipse.rse.logging.Logger;
import org.eclipse.swt.SWT; import org.eclipse.swt.SWT;
import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridData;
import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.layout.GridLayout;
@ -94,8 +95,10 @@ public abstract class LoggingPreferencePage extends PreferencePage implements IW
radioButton1 = createRadioButton(composite1_radioButton, LabelUtil.assignMnemonic(text, used)); radioButton1 = createRadioButton(composite1_radioButton, LabelUtil.assignMnemonic(text, used));
text = LoggingPreferenceLabels.LOGGING_PREFERENCE_PAGE_INFO_DEBUG; text = LoggingPreferenceLabels.LOGGING_PREFERENCE_PAGE_INFO_DEBUG;
radioButton2 = createRadioButton(composite1_radioButton, LabelUtil.assignMnemonic(text, used)); radioButton2 = createRadioButton(composite1_radioButton, LabelUtil.assignMnemonic(text, used));
text = LoggingPreferenceLabels.LOGGING_PREFERENCE_PAGE_FULL_DEBUG; if (Logger.DEBUG) {
radioButton3 = createRadioButton(composite1_radioButton, LabelUtil.assignMnemonic(text, used)); text = LoggingPreferenceLabels.LOGGING_PREFERENCE_PAGE_FULL_DEBUG;
radioButton3 = createRadioButton(composite1_radioButton, LabelUtil.assignMnemonic(text, used));
}
initializeValues(); initializeValues();
PlatformUI.getWorkbench().getHelpSystem().setHelp(parent, "org.eclipse.rse.logging.rsel0000"); PlatformUI.getWorkbench().getHelpSystem().setHelp(parent, "org.eclipse.rse.logging.rsel0000");
return new Composite(parent, SWT.NULL); return new Composite(parent, SWT.NULL);