mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-10 17:55:39 +02:00
Code Issues Wiki Activity

[299019] CMemoryBlockExtension does not correctly implement IMemoryBlockExtension#setBaseAddress. Applied patch with some modifications.

Browse source
This commit is contained in:
John Cortell 2010-01-13 17:12:02 +00:00
parent df738ce07d
commit 6d324d7f03
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CMemoryBlockExtension.java
View file

@ -175,14 +175,19 @@ public class CMemoryBlockExtension extends CDebugElement implements IMemoryBlock
* @see org.eclipse.debug.core.model.IMemoryBlockExtension#setBaseAddress(java.math.BigInteger) * @see org.eclipse.debug.core.model.IMemoryBlockExtension#setBaseAddress(java.math.BigInteger)
*/ */
public void setBaseAddress( BigInteger address ) throws DebugException { public void setBaseAddress( BigInteger address ) throws DebugException {
BigInteger current = fBaseAddress;
if (current == address || (current != null && current.equals(address))) {
return; // optimization
}
fBaseAddress = address;
fireChangeEvent(DebugEvent.STATE);
} }
/* (non-Javadoc) /* (non-Javadoc)
* @see org.eclipse.debug.core.model.IMemoryBlockExtension#getBytesFromOffset(java.math.BigInteger, long) * @see org.eclipse.debug.core.model.IMemoryBlockExtension#getBytesFromOffset(java.math.BigInteger, long)
*/ */
public MemoryByte[] getBytesFromOffset( BigInteger unitOffset, long addressableUnits ) throws DebugException { public MemoryByte[] getBytesFromOffset( BigInteger unitOffset, long addressableUnits ) throws DebugException {
// TODO Auto-generated method stub return getBytesFromAddress(unitOffset.add(getBigBaseAddress()) , addressableUnits);
return null;
} }
/* (non-Javadoc) /* (non-Javadoc)

4
memory/org.eclipse.cdt.debug.ui.memory.traditional/src/org/eclipse/cdt/debug/ui/memory/traditional/Rendering.java
View file

@ -1110,7 +1110,9 @@ public class Rendering extends Composite implements IDebugEventSetListener
try try
{ {
getMemoryBlock().setValue(address.subtract(fParent.getBigBaseAddress()), byteValue); IMemoryBlockExtension block = getMemoryBlock();
BigInteger offset = address.subtract(block.getBigBaseAddress());
block.setValue(offset, byteValue);
} }
catch(Exception e) catch(Exception e)
{ {