mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-07 17:56:01 +02:00
Code Issues Wiki Activity

Bug 399146 - Bogus 'statement has no effect' warning for call to

Browse source 
overloaded operator

Change-Id: Ie2092903356e048d96b8507ce30ec2d3edc2b2f7
Signed-off-by: Nathan Ridge <zeratul976@hotmail.com>
Reviewed-on: https://git.eclipse.org/r/14534
Reviewed-by: Sergey Prigogin <eclipse.sprigogin@gmail.com>
IP-Clean: Sergey Prigogin <eclipse.sprigogin@gmail.com>
Tested-by: Sergey Prigogin <eclipse.sprigogin@gmail.com>
This commit is contained in:
Nathan Ridge 2013-07-14 02:24:22 -04:00 • committed by Sergey Prigogin
parent 834ea8172c
commit 70c9a7b642
2 changed files with 40 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/StatementHasNoEffectChecker.java
View file

@ -82,6 +82,8 @@ public class StatementHasNoEffectChecker extends AbstractIndexAstChecker {
IASTBinaryExpression binExpr = (IASTBinaryExpression) e; IASTBinaryExpression binExpr = (IASTBinaryExpression) e;
if (isPossibleAssignment(binExpr)) if (isPossibleAssignment(binExpr))
return false; return false;
if (usesOverloadedOperator(binExpr))
return false;
switch (binExpr.getOperator()) { switch (binExpr.getOperator()) {
case IASTBinaryExpression.op_logicalOr: case IASTBinaryExpression.op_logicalOr:
case IASTBinaryExpression.op_logicalAnd: case IASTBinaryExpression.op_logicalAnd:
@ -91,6 +93,8 @@ public class StatementHasNoEffectChecker extends AbstractIndexAstChecker {
} }
if (e instanceof IASTUnaryExpression) { if (e instanceof IASTUnaryExpression) {
IASTUnaryExpression unaryExpr = (IASTUnaryExpression) e; IASTUnaryExpression unaryExpr = (IASTUnaryExpression) e;
if (usesOverloadedOperator(unaryExpr))
return false;
int operator = unaryExpr.getOperator(); int operator = unaryExpr.getOperator();
switch (operator) { switch (operator) {
case IASTUnaryExpression.op_postFixDecr: case IASTUnaryExpression.op_postFixDecr:
@ -131,14 +135,14 @@ public class StatementHasNoEffectChecker extends AbstractIndexAstChecker {
CheckersMessages.GenericParameter_ParameterExceptionsItem); CheckersMessages.GenericParameter_ParameterExceptionsItem);
} }
public boolean isFilteredArg(String arg) { private boolean isFilteredArg(String arg) {
return isFilteredArg(arg, getProblemById(ER_ID, getFile()), PARAM_EXCEPT_ARG_LIST); return isFilteredArg(arg, getProblemById(ER_ID, getFile()), PARAM_EXCEPT_ARG_LIST);
} }
/** /**
* @return * @return
*/ */
public boolean shouldReportInMacro() { private boolean shouldReportInMacro() {
return (Boolean) getPreference(getProblemById(ER_ID, getFile()), PARAM_MACRO_ID); return (Boolean) getPreference(getProblemById(ER_ID, getFile()), PARAM_MACRO_ID);
} }
@ -157,15 +161,31 @@ public class StatementHasNoEffectChecker extends AbstractIndexAstChecker {
case IASTBinaryExpression.op_shiftRightAssign: case IASTBinaryExpression.op_shiftRightAssign:
return true; return true;
} }
return false;
}
private boolean usesOverloadedOperator(IASTBinaryExpression expr) {
if (expr instanceof IASTImplicitNameOwner) { if (expr instanceof IASTImplicitNameOwner) {
// Check whether the operator is overloaded
IASTImplicitName[] implicitNames = ((IASTImplicitNameOwner) expr).getImplicitNames(); IASTImplicitName[] implicitNames = ((IASTImplicitNameOwner) expr).getImplicitNames();
if (implicitNames.length > 0) if (implicitNames.length > 0)
return true; return true;
IType expressionType = expr.getOperand1().getExpressionType(); IType operand1Type = expr.getOperand1().getExpressionType();
if (!(expressionType instanceof IBasicType)) { IType operand2Type = expr.getOperand2().getExpressionType();
return true; // must be overloaded but parser could not if (!(operand1Type instanceof IBasicType && operand2Type instanceof IBasicType)) {
// find it return true; // must be overloaded but parser could not find it
}
}
return false;
}
private boolean usesOverloadedOperator(IASTUnaryExpression expr) {
if (expr instanceof IASTImplicitNameOwner) {
IASTImplicitName[] implicitNames = ((IASTImplicitNameOwner) expr).getImplicitNames();
if (implicitNames.length > 0)
return true;
IType operandType = expr.getOperand().getExpressionType();
if (!(operandType instanceof IBasicType)) {
return true; // must be overloaded but parser could not find it
} }
} }
return false; return false;

13
codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/internal/checkers/StatementHasNoEffectCheckerTest.java
View file

@ -187,4 +187,17 @@ public class StatementHasNoEffectCheckerTest extends CheckerTestCase {
IMarker m = checkErrorLine(3); IMarker m = checkErrorLine(3);
assertMessageMatch("'\\+a'", m); //$NON-NLS-1$ assertMessageMatch("'\\+a'", m); //$NON-NLS-1$
} }
// class S {
// int operator*(); // may have side effect
// };
//
// int main() {
// S s;
// *s;
// }
public void testOverloadedOperator_bug399146() {
loadCodeAndRunCpp(getAboveComment());
checkNoErrors();
}
} }