From 7273934121a7d2ef94fdf690daa85b04bf85367d Mon Sep 17 00:00:00 2001 From: Marc Khouzam Date: Fri, 6 May 2011 19:35:05 +0000 Subject: [PATCH] Bug 345019: Harmless race condition between stopping tracking breakpoints and GDB shutdown causes unnecessary error printout --- .../org/eclipse/cdt/dsf/gdb/service/GDBProcesses_7_2.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBProcesses_7_2.java b/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBProcesses_7_2.java index f5c946420bf..61f922f779f 100644 --- a/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBProcesses_7_2.java +++ b/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBProcesses_7_2.java @@ -374,7 +374,13 @@ public class GDBProcesses_7_2 extends GDBProcesses_7_1 { IBreakpointsTargetDMContext bpTargetDmc = DMContexts.getAncestorOfType(dmc, IBreakpointsTargetDMContext.class); MIBreakpointsManager bpmService = getServicesTracker().getService(MIBreakpointsManager.class); if (bpmService != null) { - bpmService.stopTrackingBreakpoints(bpTargetDmc, new RequestMonitor(ImmediateExecutor.getInstance(), null)); + bpmService.stopTrackingBreakpoints(bpTargetDmc, new RequestMonitor(ImmediateExecutor.getInstance(), null) { + @Override + protected void handleCompleted() { + // Ok, no need to report any error because we may have already shutdown. + // We need to override handleCompleted to avoid risking having a error printout in the log + } + }); } } }