mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-29 03:45:35 +02:00
Code Issues Wiki Activity

[182454] improve getAbsoluteName() documentation

Browse source
This commit is contained in:
Martin Oberhuber 2007-04-25 11:41:25 +00:00
parent d31ac6c82c
commit 7fc7c243b4
5 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
rse/examples/org.eclipse.rse.examples.daytime/src/org/eclipse/rse/examples/daytime/model/DaytimeResourceAdapter.java
View file

@ -57,6 +57,7 @@ public class DaytimeResourceAdapter extends AbstractSystemViewAdapter implements
public String getAbsoluteName(Object object) { public String getAbsoluteName(Object object) {
//Not used since we dont support clipboard copy, rename or filtering //Not used since we dont support clipboard copy, rename or filtering
//FIXME absolute name must remain unique for the object over its lifetime
return "daytime:"+getText(object); //$NON-NLS-1$ return "daytime:"+getText(object); //$NON-NLS-1$
} }

1
rse/plugins/org.eclipse.rse.files.ui/src/org/eclipse/rse/internal/files/ui/view/SystemViewRemoteSearchResultSetAdapter.java
View file

@ -179,6 +179,7 @@ public class SystemViewRemoteSearchResultSetAdapter extends AbstractSystemViewAd
*/ */
public String getAbsoluteName(Object element) public String getAbsoluteName(Object element)
{ {
//FIXME this is forbidden by the API
return null; return null;
} }

1
rse/plugins/org.eclipse.rse.shells.ui/src/org/eclipse/rse/shells/ui/view/SystemViewRemoteOutputAdapter.java
View file

@ -699,6 +699,7 @@ implements ISystemViewElementAdapter, ISystemRemoteElementAdapter
String str = getAbsoluteParentName(element); String str = getAbsoluteParentName(element);
return str + ":" + out.getIndex(); //$NON-NLS-1$ return str + ":" + out.getIndex(); //$NON-NLS-1$
} }
//FIXME this should never happen
return null; return null;
} }

2
rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/SystemViewSubSystemAdapter.java
View file

@ -150,6 +150,8 @@ public class SystemViewSubSystemAdapter extends AbstractSystemViewAdapter
ISubSystem ss = (ISubSystem)element; ISubSystem ss = (ISubSystem)element;
// DKM - using type instead of name // DKM - using type instead of name
//FIXME can we guarantee that the serviceType is always different than the subsystemName?
//Or could the two be confused when looking up the subsystem the reverse way?
if (ss instanceof IServiceSubSystem) if (ss instanceof IServiceSubSystem)
{ {
return ss.getSystemProfileName() + "." + ss.getHostAliasName() + "." + ((IServiceSubSystem)ss).getServiceType(); //$NON-NLS-1$ //$NON-NLS-2$ return ss.getSystemProfileName() + "." + ss.getHostAliasName() + "." + ((IServiceSubSystem)ss).getServiceType(); //$NON-NLS-1$ //$NON-NLS-2$

16
rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/internal/testsubsystem/TestSubSystemNodeAdapter.java
View file

@ -81,17 +81,15 @@ public class TestSubSystemNodeAdapter extends AbstractSystemViewAdapter
* @see org.eclipse.rse.core.subsystems.IRemoteObjectIdentifier#getAbsoluteName(java.lang.Object) * @see org.eclipse.rse.core.subsystems.IRemoteObjectIdentifier#getAbsoluteName(java.lang.Object)
*/ */
public String getAbsoluteName(Object element) { public String getAbsoluteName(Object element) {
if (isTestSubSystemNode(element)) { assert isTestSubSystemNode(element);
ITestSubSystemNode node = (ITestSubSystemNode) element; ITestSubSystemNode node = (ITestSubSystemNode) element;
String absName = node.getName(); String absName = node.getName();
node = node.getParent();
while (node != null) {
absName = node.getName() + "/" + absName; //$NON-NLS-1$
node = node.getParent(); node = node.getParent();
while (node != null) {
absName = node.getName() + "/" + absName; //$NON-NLS-1$
node = node.getParent();
}
return absName;
} }
return null; return absName;
} }
/* (non-Javadoc) /* (non-Javadoc)