mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-26 02:15:31 +02:00
Code Issues Wiki Activity

[304434] ISourceLookupParticipant.getSourceName(Object) should return null, not empty string

Browse source
This commit is contained in:
John Cortell 2010-03-02 23:13:33 +00:00
parent 324bc25ac9
commit 8868796244
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/sourcelookup/DsfSourceLookupParticipant.java
View file

@ -193,7 +193,12 @@ public class DsfSourceLookupParticipant implements ISourceLookupParticipant {
}}; }};
fExecutor.execute(query); fExecutor.execute(query);
try { try {
return query.get(); String result = query.get();
if ((result != null) && (result.length() == 0)) {
// interface javadoc says we should return null
result = null;
}
return result;
} catch (InterruptedException e) { assert false : "Interrupted exception in DSF executor"; //$NON-NLS-1$ } catch (InterruptedException e) { assert false : "Interrupted exception in DSF executor"; //$NON-NLS-1$
} catch (ExecutionException e) { } catch (ExecutionException e) {
if (e.getCause() instanceof CoreException) { if (e.getCause() instanceof CoreException) {