mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-06 17:26:01 +02:00
Code Issues Wiki Activity

bug 371797: prevent possible deadlock for specs detectors

Browse source
This commit is contained in:
Andrew Gvozdev 2012-04-14 13:07:36 -04:00
parent d474c67844
commit 8fbf618249
1 changed files with 15 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/language/settings/providers/LanguageSettingsProvidersSerializer.java
View file

@ -105,6 +105,7 @@ public class LanguageSettingsProvidersSerializer {
private static ListenerList fLanguageSettingsChangeListeners = new ListenerList(ListenerList.IDENTITY);
private static ILock serializingLock = Job.getJobManager().newLock();
private static ILock serializingLockWsp = Job.getJobManager().newLock();
/**
* Dummy class to represent ill-defined provider.
@ -468,21 +469,21 @@ public class LanguageSettingsProvidersSerializer {
IProject[] projects = root.getProjects();
for (IProject project : projects) {
try {
if (project.isAccessible()) {
ICProjectDescription prjDescription = CCorePlugin.getDefault().getProjectDescription(project, false);
if (prjDescription != null) {
try {
LanguageSettingsChangeEvent event = createEvent(prjDescription, providerIds);
if (event != null) {
events.add(event);
}
}
}
} catch (Throwable e) {
// log and swallow any exception
CCorePlugin.log("Error creating event about changes in workspace language settings providers, " //$NON-NLS-1$
+ "project=" + project.getName(), e); //$NON-NLS-1$
}
}
}
}
@ -508,12 +509,12 @@ public class LanguageSettingsProvidersSerializer {
if (serializableWorkspaceProviders.isEmpty()) {
java.io.File fileStoreWsp = new java.io.File(uriStoreWsp);
try {
serializingLock.acquire();
serializingLockWsp.acquire();
fileStoreWsp.delete();
// manufacture events while inside the lock
events = createLanguageSettingsChangeEvents(serializableWorkspaceProviders);
} finally {
serializingLock.release();
serializingLockWsp.release();
}
} else {
Document doc = XmlUtil.newDocument();
@ -526,12 +527,12 @@ public class LanguageSettingsProvidersSerializer {
}
try {
serializingLock.acquire();
serializingLockWsp.acquire();
XmlUtil.serializeXml(doc, uriStoreWsp);
// manufacture events while inside the lock
events = createLanguageSettingsChangeEvents(serializableWorkspaceProviders);
} finally {
serializingLock.release();
serializingLockWsp.release();
}
}
// notify the listeners outside the lock
@ -596,12 +597,12 @@ public class LanguageSettingsProvidersSerializer {
Document doc = null;
try {
serializingLock.acquire();
serializingLockWsp.acquire();
doc = XmlUtil.loadXml(uriStoreWsp);
} catch (Exception e) {
CCorePlugin.log("Can't load preferences from file " + uriStoreWsp, e); //$NON-NLS-1$
} finally {
serializingLock.release();
serializingLockWsp.release();
}
if (doc != null) {