1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00

Cosmetics.

This commit is contained in:
Sergey Prigogin 2011-05-26 00:02:13 +00:00
parent 165d5a38af
commit 97c5ac2ec6

View file

@ -38,13 +38,12 @@ import org.eclipse.ui.PlatformUI;
* A preference page for settings that are currently only supported in GDB. * A preference page for settings that are currently only supported in GDB.
*/ */
public class GdbDebugPreferencePage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage { public class GdbDebugPreferencePage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage {
/** /**
* A vehicle in order to be able to register a selection listener with * A vehicle in order to be able to register a selection listener with
* a {@link BooleanFieldEditor}. * a {@link BooleanFieldEditor}.
*/ */
private class ListenableBooleanFieldEditor extends BooleanFieldEditor { private class ListenableBooleanFieldEditor extends BooleanFieldEditor {
public ListenableBooleanFieldEditor( public ListenableBooleanFieldEditor(
String name, String name,
String labelText, String labelText,
@ -63,7 +62,7 @@ public class GdbDebugPreferencePage extends FieldEditorPreferencePage implements
super(FLAT); super(FLAT);
IPreferenceStore store= GdbUIPlugin.getDefault().getPreferenceStore(); IPreferenceStore store= GdbUIPlugin.getDefault().getPreferenceStore();
setPreferenceStore(store); setPreferenceStore(store);
setDescription(MessagesForPreferences.GdbDebugPreferencePage_description); setDescription(MessagesForPreferences.GdbDebugPreferencePage_description);
} }
public void init(IWorkbench workbench) { public void init(IWorkbench workbench) {
@ -81,13 +80,13 @@ public class GdbDebugPreferencePage extends FieldEditorPreferencePage implements
final GridLayout layout= new GridLayout(); final GridLayout layout= new GridLayout();
layout.marginWidth= 0; layout.marginWidth= 0;
parent.setLayout(layout); parent.setLayout(layout);
Group group = new Group(parent, SWT.NONE); Group group = new Group(parent, SWT.NONE);
group.setText(MessagesForPreferences.GdbDebugPreferencePage_defaults_label); group.setText(MessagesForPreferences.GdbDebugPreferencePage_defaults_label);
GridLayout groupLayout = new GridLayout(3, false); GridLayout groupLayout = new GridLayout(3, false);
group.setLayout(groupLayout); group.setLayout(groupLayout);
group.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); group.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
final StringFieldEditor stringFieldEditorCommand = new StringFieldEditor( final StringFieldEditor stringFieldEditorCommand = new StringFieldEditor(
IGdbDebugPreferenceConstants.PREF_DEFAULT_GDB_COMMAND, IGdbDebugPreferenceConstants.PREF_DEFAULT_GDB_COMMAND,
LaunchUIMessages.getString("GDBDebuggerPage.gdb_debugger"), //$NON-NLS-1$ LaunchUIMessages.getString("GDBDebuggerPage.gdb_debugger"), //$NON-NLS-1$
@ -104,7 +103,7 @@ public class GdbDebugPreferencePage extends FieldEditorPreferencePage implements
stringFieldEditorCommand); stringFieldEditorCommand);
} }
}); });
final StringFieldEditor stringFieldEditorGdbInit = new StringFieldEditor( final StringFieldEditor stringFieldEditorGdbInit = new StringFieldEditor(
IGdbDebugPreferenceConstants.PREF_DEFAULT_GDB_INIT, IGdbDebugPreferenceConstants.PREF_DEFAULT_GDB_INIT,
LaunchUIMessages.getString("GDBDebuggerPage.gdb_command_file"), //$NON-NLS-1$ LaunchUIMessages.getString("GDBDebuggerPage.gdb_command_file"), //$NON-NLS-1$
@ -121,7 +120,7 @@ public class GdbDebugPreferencePage extends FieldEditorPreferencePage implements
stringFieldEditorGdbInit); stringFieldEditorGdbInit);
} }
}); });
group.setLayout(groupLayout); group.setLayout(groupLayout);
group= new Group(parent, SWT.NONE); group= new Group(parent, SWT.NONE);
@ -144,7 +143,7 @@ public class GdbDebugPreferencePage extends FieldEditorPreferencePage implements
group); group);
// Instead of using Integer.MAX_VALUE which is some obscure number, using 2 billion is nice and readable // Instead of using Integer.MAX_VALUE which is some obscure number, using 2 billion is nice and readable
maxCharactersField.setValidRange(10000, 2000000000); maxCharactersField.setValidRange(10000, 2000000000);
maxCharactersField.fillIntoGrid(group, 3); maxCharactersField.fillIntoGrid(group, 3);
addField(maxCharactersField); addField(maxCharactersField);
@ -152,14 +151,14 @@ public class GdbDebugPreferencePage extends FieldEditorPreferencePage implements
enableGdbTracesField.getChangeControl(group).addSelectionListener(new SelectionAdapter() { enableGdbTracesField.getChangeControl(group).addSelectionListener(new SelectionAdapter() {
@Override @Override
public void widgetSelected(SelectionEvent e) { public void widgetSelected(SelectionEvent e) {
boolean enabled = enableGdbTracesField.getBooleanValue(); boolean enabled = enableGdbTracesField.getBooleanValue();
maxCharactersField.setEnabled(enabled, finalGroup); maxCharactersField.setEnabled(enabled, finalGroup);
} }
}); });
// need to set layout again // need to set layout again
group.setLayout(groupLayout); group.setLayout(groupLayout);
group= new Group(parent, SWT.NONE); group= new Group(parent, SWT.NONE);
group.setText(MessagesForPreferences.GdbDebugPreferencePage_termination_label); group.setText(MessagesForPreferences.GdbDebugPreferencePage_termination_label);
groupLayout= new GridLayout(3, false); groupLayout= new GridLayout(3, false);
@ -206,19 +205,19 @@ public class GdbDebugPreferencePage extends FieldEditorPreferencePage implements
enablePrettyPrintingField.fillIntoGrid(group, 3); enablePrettyPrintingField.fillIntoGrid(group, 3);
addField(enablePrettyPrintingField); addField(enablePrettyPrintingField);
final Composite indentHelper = new Composite(group, SWT.NONE); final Composite indentHelper = new Composite(group, SWT.NONE);
GridLayout helperLayout = new GridLayout(3, false); GridLayout helperLayout = new GridLayout(3, false);
indentHelper.setLayout(helperLayout); indentHelper.setLayout(helperLayout);
GridData helperData = new GridData(SWT.FILL, SWT.FILL, true, false, 3, 1); GridData helperData = new GridData(SWT.FILL, SWT.FILL, true, false, 3, 1);
helperData.horizontalIndent = 20; helperData.horizontalIndent = 20;
indentHelper.setLayoutData(helperData); indentHelper.setLayoutData(helperData);
final IntegerFieldEditor childCountLimitField = new IntegerFieldEditor( final IntegerFieldEditor childCountLimitField = new IntegerFieldEditor(
IGdbDebugPreferenceConstants.PREF_INITIAL_CHILD_COUNT_LIMIT_FOR_COLLECTIONS, IGdbDebugPreferenceConstants.PREF_INITIAL_CHILD_COUNT_LIMIT_FOR_COLLECTIONS,
MessagesForPreferences.GdbDebugPreferencePage_initialChildCountLimitForCollections_label, MessagesForPreferences.GdbDebugPreferencePage_initialChildCountLimitForCollections_label,
indentHelper); indentHelper);
childCountLimitField.setValidRange(1, 10000); childCountLimitField.setValidRange(1, 10000);
childCountLimitField.fillIntoGrid(indentHelper, 3); childCountLimitField.fillIntoGrid(indentHelper, 3);
@ -226,23 +225,22 @@ public class GdbDebugPreferencePage extends FieldEditorPreferencePage implements
boolean prettyPrintingEnabled = store boolean prettyPrintingEnabled = store
.getBoolean(IGdbDebugPreferenceConstants.PREF_ENABLE_PRETTY_PRINTING); .getBoolean(IGdbDebugPreferenceConstants.PREF_ENABLE_PRETTY_PRINTING);
childCountLimitField.setEnabled(prettyPrintingEnabled, indentHelper); childCountLimitField.setEnabled(prettyPrintingEnabled, indentHelper);
addField(childCountLimitField); addField(childCountLimitField);
enablePrettyPrintingField.getChangeControl(group).addSelectionListener(new SelectionAdapter() { enablePrettyPrintingField.getChangeControl(group).addSelectionListener(new SelectionAdapter() {
@Override @Override
public void widgetSelected(SelectionEvent e) { public void widgetSelected(SelectionEvent e) {
boolean enabled = enablePrettyPrintingField.getBooleanValue(); boolean enabled = enablePrettyPrintingField.getBooleanValue();
childCountLimitField.setEnabled(enabled, indentHelper); childCountLimitField.setEnabled(enabled, indentHelper);
} }
}); });
// need to set layouts again // need to set layouts again
indentHelper.setLayout(helperLayout); indentHelper.setLayout(helperLayout);
group.setLayout(groupLayout); group.setLayout(groupLayout);
} }
private void handleBrowseButtonSelected(final String dialogTitle, final StringFieldEditor stringFieldEditor) { private void handleBrowseButtonSelected(final String dialogTitle, final StringFieldEditor stringFieldEditor) {
FileDialog dialog = new FileDialog(getShell(), SWT.NONE); FileDialog dialog = new FileDialog(getShell(), SWT.NONE);
dialog.setText(dialogTitle); dialog.setText(dialogTitle);