mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-09 02:36:01 +02:00
Code Issues Wiki Activity

Reverse part of a patch from TF concerning

Browse source 
memory images. We need to look at this closer.
	For now it seem to break some icons.

	* src/org/eclipse/cdt/internal/ui/CPluginImages.java
This commit is contained in:
Alain Magloire 2004-05-28 17:10:18 +00:00
parent 7a38ea6afb
commit a677717aa3
2 changed files with 20 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/org.eclipse.cdt.ui/ChangeLog
View file

@ -1,3 +1,11 @@
2004-05-27 Alain Magloire
Reverse part of a patch from TF concerning
memory images. We need to look at this closer.
For now it seem to break some icons.
* src/org/eclipse/cdt/internal/ui/CPluginImages.java
2004-05-27 Alain Magloire 2004-05-27 Alain Magloire
Patch from Thomas Fletcher Patch from Thomas Fletcher

23
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/CPluginImages.java
View file

@ -262,18 +262,19 @@ public class CPluginImages {
* Sets all available image descriptors for the given action. * Sets all available image descriptors for the given action.
*/ */
public static void setImageDescriptors(IAction action, String type, String relPath) { public static void setImageDescriptors(IAction action, String type, String relPath) {
//Use the managed version so that we ensure that there is no resource handle leaks relPath= relPath.substring(NAME_PREFIX_LENGTH);
//Let the widget itself manage the disabled/hover attribution. This was a huge leak action.setDisabledImageDescriptor(create(T + "d" + type, relPath)); //$NON-NLS-1$
// relPath= relPath.substring(NAME_PREFIX_LENGTH); action.setHoverImageDescriptor(create(T + "c" + type, relPath)); //$NON-NLS-1$
// action.setDisabledImageDescriptor(create(T + "d" + type, relPath)); //$NON-NLS-1$ action.setImageDescriptor(create(T + "e" + type, relPath)); //$NON-NLS-1$
// action.setHoverImageDescriptor(create(T + "c" + type, relPath)); //$NON-NLS-1$
// action.setImageDescriptor(create(T + "e" + type, relPath)); //$NON-NLS-1$
ImageDescriptor desc = getImageRegistry().getDescriptor(relPath); // We are still not sure about this, let see TF results first.
if(desc == null) { // Use the managed version so that we ensure that there is no resource handle leaks
desc = createManaged(T + "c" + type, relPath); // Let the widget itself manage the disabled/hover attribution. This was a huge leak
} //ImageDescriptor desc = getImageRegistry().getDescriptor(relPath);
action.setImageDescriptor(desc); //if(desc == null) {
// desc = createManaged(T + "c" + type, relPath);
//}
//action.setImageDescriptor(desc);
} }
/** /**