mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

Use SafeRunner in LanguageSettingsProviderTab

Browse source 
If an option page contributed by an extension throws an exception,
then none of the other pages get created. It is better to use a
SafeRunner when in such case where plugins could break other things
than its own functionality.

Change-Id: I531c966be8ef6460a838b3d10bc61dcbdbe627b0
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
This commit is contained in:
Marc-Andre Laperle 2019-09-28 00:37:26 -04:00 • committed by Marc-André Laperle
parent 4e16631f30
commit a71a413500
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/language/settings/providers/LanguageSettingsProviderTab.java
View file

@ -40,6 +40,7 @@ import org.eclipse.cdt.ui.newui.AbstractCPropertyTab;
import org.eclipse.cdt.utils.ui.controls.TabFolderLayout; import org.eclipse.cdt.utils.ui.controls.TabFolderLayout;
import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.SafeRunner;
import org.eclipse.core.runtime.Status; import org.eclipse.core.runtime.Status;
import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.MessageDialog;
import org.eclipse.jface.viewers.ArrayContentProvider; import org.eclipse.jface.viewers.ArrayContentProvider;
@ -1075,7 +1076,9 @@ public class LanguageSettingsProviderTab extends AbstractCPropertyTab {
optionsPageMap.clear(); optionsPageMap.clear();
for (ILanguageSettingsProvider provider : presentedProviders) { for (ILanguageSettingsProvider provider : presentedProviders) {
createOptionsPage(provider); SafeRunner.run(() -> {
createOptionsPage(provider);
});
} }
displaySelectedOptionPage(); displaySelectedOptionPage();