mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-08 18:26:01 +02:00
Code Issues Wiki Activity

A change in VCErrorParser to fix PR 53253 causes an IndexOutOfBounds exception when echoing a build command on Win32 if the absolute path to the make utility is specified, i.e. C:\<path>\make.exe. The work-around is to not have the launcher echo the command, and just output it to the build console directly.

Browse source
This commit is contained in:
Sean Evoy 2004-03-03 15:09:16 +00:00
parent 72d4589838
commit a84395e43f
3 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
build/org.eclipse.cdt.managedbuilder.core/ChangeLog
View file

@ -1,3 +1,11 @@
2004-03-02 Sean Evoy
A change in VCErrorParser to fix PR 53253 causes an IndexOutOfBounds
exception when echoing a build command on Win32 if the absolute path
to the make utility is specified, i.e. C:\<path>\make.exe
The work-around is to not have the launcher echo the command, and just
output it to the build console directly.
2004-03-02 James Ciesielski 2004-03-02 James Ciesielski
Marked those strings that are non-translatable as such and externalized Marked those strings that are non-translatable as such and externalized
those strings that can be translated. There is still work to be done in those strings that can be translated. There is still work to be done in

11
build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/GeneratedMakefileBuilder.java
View file

@ -348,7 +348,7 @@ public class GeneratedMakefileBuilder extends ACBuilder {
// Get a launcher for the make command // Get a launcher for the make command
String errMsg = null; String errMsg = null;
CommandLauncher launcher = new CommandLauncher(); CommandLauncher launcher = new CommandLauncher();
launcher.showCommand(true); launcher.showCommand(false);
// Set the environmennt, some scripts may need the CWD var to be set. // Set the environmennt, some scripts may need the CWD var to be set.
Properties props = launcher.getEnvironment(); Properties props = launcher.getEnvironment();
@ -372,6 +372,15 @@ public class GeneratedMakefileBuilder extends ACBuilder {
OutputStream stderr = epm.getOutputStream(); OutputStream stderr = epm.getOutputStream();
// Launch make // Launch make
StringBuffer cmd = new StringBuffer();
cmd.append(makeCommand.toOSString());
for (int index = 0; index < makeTargets.length; ++index) {
cmd.append(' ');
cmd.append(makeTargets[index]);
}
cmd.append(System.getProperty("line.separator", "\n")); //$NON-NLS-2$
consoleOutStream.write(cmd.toString().getBytes());
consoleOutStream.flush();
Process proc = launcher.execute(makeCommand, makeTargets, env, workingDirectory); Process proc = launcher.execute(makeCommand, makeTargets, env, workingDirectory);
if (proc != null) { if (proc != null) {
try { try {

2
build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/PluginResources.properties
View file

@ -17,7 +17,7 @@ ManagedMakeBuilder.message.updating = Updating project files...
ManagedMakeBuilder.message.make = Calling {0} for project {1} ManagedMakeBuilder.message.make = Calling {0} for project {1}
ManagedMakeBuilder.message.creating.markers = Generating markers... ManagedMakeBuilder.message.creating.markers = Generating markers...
ManagedMakeBuilder.message.error = Build error ManagedMakeBuilder.message.error = Build error
ManagedMakeBuilder.message.error.refresh = Error refreshing project. ManagedMakeBuilder.message.error.refresh = Error refreshing project
ManagedMakeBuilder.message.finished = Build complete for project {0} ManagedMakeBuilder.message.finished = Build complete for project {0}
ManagedMakeBuilder.comment.module.list = Every subdirectory with source files must be described here ManagedMakeBuilder.comment.module.list = Every subdirectory with source files must be described here
ManagedMakeBuilder.comment.source.list = Each subdirectory must contribute its source files here ManagedMakeBuilder.comment.source.list = Each subdirectory must contribute its source files here