mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-07 09:46:02 +02:00
Code Issues Wiki Activity

Simplified code by using different API and get rid of warnings

Browse source
This commit is contained in:
Alena Laskavaia 2010-05-12 22:29:24 +00:00
parent eff03629d6
commit a88cb349f8
2 changed files with 24 additions and 42 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/StatementHasNoEffectChecker.java
View file

@ -21,12 +21,7 @@ import org.eclipse.cdt.core.dom.ast.IASTNode;
import org.eclipse.cdt.core.dom.ast.IASTStatement; import org.eclipse.cdt.core.dom.ast.IASTStatement;
import org.eclipse.cdt.core.dom.ast.IASTTranslationUnit; import org.eclipse.cdt.core.dom.ast.IASTTranslationUnit;
import org.eclipse.cdt.core.dom.ast.IASTUnaryExpression; import org.eclipse.cdt.core.dom.ast.IASTUnaryExpression;
import org.eclipse.cdt.core.dom.ast.IBasicType;
import org.eclipse.cdt.core.dom.ast.IType;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPBasicType;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPFunction;
import org.eclipse.cdt.core.dom.ast.gnu.IGNUASTCompoundStatementExpression; import org.eclipse.cdt.core.dom.ast.gnu.IGNUASTCompoundStatementExpression;
import org.eclipse.cdt.internal.core.dom.parser.cpp.CPPASTBinaryExpression;
/** /**
* Checker that detects statements without effect such as * Checker that detects statements without effect such as
@ -73,36 +68,13 @@ public class StatementHasNoEffectChecker extends AbstractIndexAstChecker {
private boolean hasNoEffect(IASTExpression e) { private boolean hasNoEffect(IASTExpression e) {
if (e instanceof IASTBinaryExpression) { if (e instanceof IASTBinaryExpression) {
IASTBinaryExpression binExpr = (IASTBinaryExpression) e; IASTBinaryExpression binExpr = (IASTBinaryExpression) e;
switch (binExpr.getOperator()) { if (binExpr.isLValue())
case IASTBinaryExpression.op_assign:
case IASTBinaryExpression.op_binaryAndAssign:
case IASTBinaryExpression.op_binaryOrAssign:
case IASTBinaryExpression.op_binaryXorAssign:
case IASTBinaryExpression.op_divideAssign:
case IASTBinaryExpression.op_plusAssign:
case IASTBinaryExpression.op_minusAssign:
case IASTBinaryExpression.op_multiplyAssign:
case IASTBinaryExpression.op_moduloAssign:
case IASTBinaryExpression.op_shiftLeftAssign:
case IASTBinaryExpression.op_shiftRightAssign:
return false; return false;
case IASTBinaryExpression.op_logicalOr: switch (binExpr.getOperator()) {
case IASTBinaryExpression.op_logicalAnd: case IASTBinaryExpression.op_logicalOr:
return hasNoEffect(binExpr.getOperand1()) case IASTBinaryExpression.op_logicalAnd:
&& hasNoEffect(binExpr.getOperand2()); return hasNoEffect(binExpr.getOperand1())
} && hasNoEffect(binExpr.getOperand2());
if (binExpr instanceof CPPASTBinaryExpression) {
// unfortunately ICPPASTBinaryExpression does not have
// getOverload public method
CPPASTBinaryExpression cppBin = (CPPASTBinaryExpression) binExpr;
ICPPFunction overload = cppBin.getOverload();
if (overload != null)
return false;
IType expressionType = binExpr.getOperand1()
.getExpressionType();
if (!(expressionType instanceof IBasicType || expressionType instanceof ICPPBasicType)) {
return false; // must be overloaded but parser could not find it
}
} }
return true; return true;
} }
@ -110,14 +82,14 @@ public class StatementHasNoEffectChecker extends AbstractIndexAstChecker {
IASTUnaryExpression unaryExpr = (IASTUnaryExpression) e; IASTUnaryExpression unaryExpr = (IASTUnaryExpression) e;
int operator = unaryExpr.getOperator(); int operator = unaryExpr.getOperator();
switch (operator) { switch (operator) {
case IASTUnaryExpression.op_postFixDecr: case IASTUnaryExpression.op_postFixDecr:
case IASTUnaryExpression.op_prefixDecr: case IASTUnaryExpression.op_prefixDecr:
case IASTUnaryExpression.op_postFixIncr: case IASTUnaryExpression.op_postFixIncr:
case IASTUnaryExpression.op_prefixIncr: case IASTUnaryExpression.op_prefixIncr:
case IASTUnaryExpression.op_throw: case IASTUnaryExpression.op_throw:
return false; return false;
case IASTUnaryExpression.op_bracketedPrimary: case IASTUnaryExpression.op_bracketedPrimary:
return hasNoEffect(unaryExpr.getOperand()); return hasNoEffect(unaryExpr.getOperand());
} }
return true; return true;
} }

10
codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/internal/checkers/StatementHasNoEffectCheckerTest.java
View file

@ -123,4 +123,14 @@ public class StatementHasNoEffectCheckerTest extends CheckerTestCase {
loadCodeAndRunCpp(getAboveComment()); loadCodeAndRunCpp(getAboveComment());
checkNoErrors(); checkNoErrors();
} }
// main() {
// A a,b;
//
// b+=a; // error here on line 4
// }
public void testOverloadedBinaryExpression() {
loadCodeAndRun(getAboveComment());
checkNoErrors();
}
} }