mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-03 15:15:25 +02:00
Code Issues Wiki Activity

Bug 529383 - NPE in CheckersRegistry.getResourceProfile()

Browse source 
Change-Id: I376cbf44c1fd237bd75a98ffc9e1daf60f5924ec
This commit is contained in:
Nathan Ridge 2018-02-08 20:42:17 -05:00
parent 276fda83a5
commit a8cf65fa75
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
codan/org.eclipse.cdt.codan.checkers.ui/src/org/eclipse/cdt/codan/internal/checkers/ui/quickfix/CaseBreakQuickFixFallthroughAttribute.java
View file

@ -29,6 +29,9 @@ public class CaseBreakQuickFixFallthroughAttribute extends AbstractCaseBreakQuic
@Override @Override
public boolean isApplicable(IMarker marker) { public boolean isApplicable(IMarker marker) {
IProblem problem = getProblem(marker); IProblem problem = getProblem(marker);
if (problem == null) {
return false;
}
RootProblemPreference map = (RootProblemPreference) problem.getPreference(); RootProblemPreference map = (RootProblemPreference) problem.getPreference();
boolean enabled = (boolean) map.getChildValue(CaseBreakChecker.PARAM_ENABLE_FALLTHROUGH_QUICKFIX); boolean enabled = (boolean) map.getChildValue(CaseBreakChecker.PARAM_ENABLE_FALLTHROUGH_QUICKFIX);
boolean last_case_enabled = (boolean) map.getChildValue(CaseBreakChecker.PARAM_LAST_CASE); boolean last_case_enabled = (boolean) map.getChildValue(CaseBreakChecker.PARAM_LAST_CASE);

5
codan/org.eclipse.cdt.codan.ui.cxx/src/org/eclipse/cdt/codan/ui/AbstractCodanCMarkerResolution.java
View file

@ -275,6 +275,11 @@ public abstract class AbstractCodanCMarkerResolution implements ICodanMarkerReso
public IProblem getProblem(IMarker marker) { public IProblem getProblem(IMarker marker) {
IResource resource = marker.getResource(); IResource resource = marker.getResource();
if (resource == null) {
// IMarker.getResource() is not supposed to return null,
// but it looks like it sometimes does (bug 529383).
return null;
}
IProblemProfile profile = CodanRuntime.getInstance().getCheckersRegistry().getResourceProfile(resource); IProblemProfile profile = CodanRuntime.getInstance().getCheckersRegistry().getResourceProfile(resource);
String id = getProblemId(marker); String id = getProblemId(marker);
return profile.findProblem(id); return profile.findProblem(id);