mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-08 09:35:23 +02:00
Code Issues Wiki Activity

Extracted the main part of the 'breakpointAdded' method into a separate method to avoid double checking.

Browse source
This commit is contained in:
Mikhail Khodjaiants 2003-11-26 22:54:29 +00:00
parent 8b1194ebfb
commit b50eb6955d
2 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
debug/org.eclipse.cdt.debug.core/ChangeLog
View file

@ -1,3 +1,8 @@
2003-11-26 Mikhail Khodjaiants
Extracted the main part of the 'breakpointAdded' method into a separate method to avoid
double checking.
* CDebugTarget.java
2003-11-10 Mikhail Khodjaiants 2003-11-10 Mikhail Khodjaiants
Ensure that all breakpoint creation and modification operations are running in the UI thread. Ensure that all breakpoint creation and modification operations are running in the UI thread.
* CBreakpointManager.java * CBreakpointManager.java

11
debug/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/internal/core/model/CDebugTarget.java
View file

@ -369,7 +369,7 @@ public class CDebugTarget extends CDebugElement
{ {
} }
} }
breakpointAdded( (ICBreakpoint)bps[i] ); breakpointAdded0( bps[i] );
} }
} }
} }
@ -691,8 +691,15 @@ public class CDebugTarget extends CDebugElement
!getBreakpointManager().isTargetBreakpoint( (ICBreakpoint)breakpoint ) || !getBreakpointManager().isTargetBreakpoint( (ICBreakpoint)breakpoint ) ||
!isAvailable() ) !isAvailable() )
return; return;
if ( breakpoint instanceof ICAddressBreakpoint && !getBreakpointManager().supportsAddressBreakpoint( (ICAddressBreakpoint)breakpoint ) ) breakpointAdded0( breakpoint );
}
private void breakpointAdded0( IBreakpoint breakpoint )
{
if ( !isAvailable() )
return; return;
if ( breakpoint instanceof ICAddressBreakpoint && !getBreakpointManager().supportsAddressBreakpoint( (ICAddressBreakpoint)breakpoint ) )
return;
if ( getConfiguration().supportsBreakpoints() ) if ( getConfiguration().supportsBreakpoints() )
{ {
try try