mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-13 12:05:21 +02:00
Code Issues Wiki Activity

[180562] [api] Classes should not implement interfaces just to bring constants into namespace. Do not implement IUniversalProcessDataStoreConstants.

Browse source
This commit is contained in:
Kushal Munir 2007-04-03 08:58:21 +00:00
parent 3789c71626
commit ba91cf7ea1
2 changed files with 25 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
rse/plugins/org.eclipse.rse.services.dstore/miners/org/eclipse/rse/dstore/universal/miners/processes/UniversalProcessMiner.java
View file

@ -44,7 +44,7 @@ import org.eclipse.rse.services.clientserver.processes.handlers.UniversalServerP
* Miner for getting process information from a remote system. * Miner for getting process information from a remote system.
* @author mjberger * @author mjberger
*/ */
public class UniversalProcessMiner extends Miner implements IUniversalProcessDataStoreConstants, IUniversalDataStoreConstants public class UniversalProcessMiner extends Miner implements IUniversalDataStoreConstants
{ {
public static final String MINER_ID = UniversalProcessMiner.class.getName(); public static final String MINER_ID = UniversalProcessMiner.class.getName();
@ -92,49 +92,49 @@ public class UniversalProcessMiner extends Miner implements IUniversalProcessDat
if (subject == null) { if (subject == null) {
UniversalServerUtilities.logError(UNIVERSAL_PROCESS_MINER, "Subject for UniversalProcessMiner command " + name + " is null", null); //$NON-NLS-1$ //$NON-NLS-2$ UniversalServerUtilities.logError(IUniversalProcessDataStoreConstants.UNIVERSAL_PROCESS_MINER, "Subject for UniversalProcessMiner command " + name + " is null", null); //$NON-NLS-1$ //$NON-NLS-2$
status.setAttribute(DE.A_NAME, "done"); //$NON-NLS-1$ status.setAttribute(DE.A_NAME, "done"); //$NON-NLS-1$
return status; return status;
} }
String subjectType = (String) subject.getElementProperty(DE.P_TYPE); String subjectType = (String) subject.getElementProperty(DE.P_TYPE);
if (name.equals(C_PROCESS_QUERY_USERNAME)) if (name.equals(IUniversalProcessDataStoreConstants.C_PROCESS_QUERY_USERNAME))
{ {
return handleQueryUserName(subject, status); return handleQueryUserName(subject, status);
} }
if (subjectType.equals(UNIVERSAL_PROCESS_FILTER)) if (subjectType.equals(IUniversalProcessDataStoreConstants.UNIVERSAL_PROCESS_FILTER))
{ {
if (name.equals(C_PROCESS_FILTER_QUERY_ALL)) if (name.equals(IUniversalProcessDataStoreConstants.C_PROCESS_FILTER_QUERY_ALL))
{ {
status = handleQuery(subject, status); status = handleQuery(subject, status);
} }
else else
{ {
UniversalServerUtilities.logError(UNIVERSAL_PROCESS_MINER, "Unknown filter command: " + name, null); //$NON-NLS-1$ UniversalServerUtilities.logError(IUniversalProcessDataStoreConstants.UNIVERSAL_PROCESS_MINER, "Unknown filter command: " + name, null); //$NON-NLS-1$
status.setAttribute(DE.A_NAME, "done"); //$NON-NLS-1$ status.setAttribute(DE.A_NAME, "done"); //$NON-NLS-1$
} }
} }
else if (subjectType.equals(UNIVERSAL_PROCESS_DESCRIPTOR)) else if (subjectType.equals(IUniversalProcessDataStoreConstants.UNIVERSAL_PROCESS_DESCRIPTOR))
{ {
if (name.equals(C_PROCESS_QUERY_ALL_PROPERTIES)) if (name.equals(IUniversalProcessDataStoreConstants.C_PROCESS_QUERY_ALL_PROPERTIES))
{ {
handleQueryJobAllProperties(subject, status); handleQueryJobAllProperties(subject, status);
} }
else if (name.equals(C_PROCESS_KILL)) else if (name.equals(IUniversalProcessDataStoreConstants.C_PROCESS_KILL))
{ {
status = handleKill(subject, status); status = handleKill(subject, status);
} }
else else
{ {
UniversalServerUtilities.logError(UNIVERSAL_PROCESS_MINER, "Unsupported process command: " + name, null); //$NON-NLS-1$ UniversalServerUtilities.logError(IUniversalProcessDataStoreConstants.UNIVERSAL_PROCESS_MINER, "Unsupported process command: " + name, null); //$NON-NLS-1$
status.setAttribute(DE.A_NAME, "done"); //$NON-NLS-1$ status.setAttribute(DE.A_NAME, "done"); //$NON-NLS-1$
} }
} }
else else
{ {
UniversalServerUtilities.logError(UNIVERSAL_PROCESS_MINER, "Unsupported subject for command: " + subject, null); //$NON-NLS-1$ UniversalServerUtilities.logError(IUniversalProcessDataStoreConstants.UNIVERSAL_PROCESS_MINER, "Unsupported subject for command: " + subject, null); //$NON-NLS-1$
status.setAttribute(DE.A_NAME, "done"); //$NON-NLS-1$ status.setAttribute(DE.A_NAME, "done"); //$NON-NLS-1$
} }
@ -161,16 +161,16 @@ public class UniversalProcessMiner extends Miner implements IUniversalProcessDat
// define process descriptors // define process descriptors
deUniversalProcessFilter = createObjectDescriptor(schemaRoot, deUniversalProcessFilter = createObjectDescriptor(schemaRoot,
UNIVERSAL_PROCESS_FILTER); IUniversalProcessDataStoreConstants.UNIVERSAL_PROCESS_FILTER);
deUniversalProcessObject = createObjectDescriptor(schemaRoot, deUniversalProcessObject = createObjectDescriptor(schemaRoot,
UNIVERSAL_PROCESS_DESCRIPTOR); IUniversalProcessDataStoreConstants.UNIVERSAL_PROCESS_DESCRIPTOR);
DataElement tempnode = createObjectDescriptor(schemaRoot, UNIVERSAL_PROCESS_TEMP); DataElement tempnode = createObjectDescriptor(schemaRoot, IUniversalProcessDataStoreConstants.UNIVERSAL_PROCESS_TEMP);
// define command descriptors // define command descriptors
createCommandDescriptor(deUniversalProcessFilter, "Filter", C_PROCESS_FILTER_QUERY_ALL); //$NON-NLS-1$ createCommandDescriptor(deUniversalProcessFilter, "Filter", IUniversalProcessDataStoreConstants.C_PROCESS_FILTER_QUERY_ALL); //$NON-NLS-1$
createCommandDescriptor(deUniversalProcessObject, "Kill", C_PROCESS_KILL); //$NON-NLS-1$ createCommandDescriptor(deUniversalProcessObject, "Kill", IUniversalProcessDataStoreConstants.C_PROCESS_KILL); //$NON-NLS-1$
createCommandDescriptor(deUniversalProcessObject, "ProcessQueryAllProperties", C_PROCESS_QUERY_ALL_PROPERTIES); //$NON-NLS-1$ createCommandDescriptor(deUniversalProcessObject, "ProcessQueryAllProperties", IUniversalProcessDataStoreConstants.C_PROCESS_QUERY_ALL_PROPERTIES); //$NON-NLS-1$
createCommandDescriptor(tempnode, "QueryUsername", C_PROCESS_QUERY_USERNAME); //$NON-NLS-1$ createCommandDescriptor(tempnode, "QueryUsername", IUniversalProcessDataStoreConstants.C_PROCESS_QUERY_USERNAME); //$NON-NLS-1$
_dataStore.refresh(schemaRoot); _dataStore.refresh(schemaRoot);
} }

14
rse/plugins/org.eclipse.rse.services.dstore/src/org/eclipse/rse/internal/services/dstore/processes/DStoreProcessService.java
View file

@ -37,7 +37,7 @@ import org.eclipse.rse.services.processes.AbstractProcessService;
import org.eclipse.rse.services.processes.IProcessService; import org.eclipse.rse.services.processes.IProcessService;
public class DStoreProcessService extends AbstractProcessService implements IProcessService, IUniversalProcessDataStoreConstants public class DStoreProcessService extends AbstractProcessService implements IProcessService
{ {
protected IDataStoreProvider _provider; protected IDataStoreProvider _provider;
protected DataElement _minerElement = null; protected DataElement _minerElement = null;
@ -74,12 +74,12 @@ public class DStoreProcessService extends AbstractProcessService implements IPro
// create filter descriptor // create filter descriptor
DataElement deObj; DataElement deObj;
deObj = ds.find(universaltemp, DE.A_NAME, UNIVERSAL_PROCESS_ROOT, 1); deObj = ds.find(universaltemp, DE.A_NAME, IUniversalProcessDataStoreConstants.UNIVERSAL_PROCESS_ROOT, 1);
if (deObj == null) deObj = ds.createObject(universaltemp, UNIVERSAL_PROCESS_FILTER, UNIVERSAL_PROCESS_ROOT, "", "", false); //$NON-NLS-1$ //$NON-NLS-2$ if (deObj == null) deObj = ds.createObject(universaltemp, IUniversalProcessDataStoreConstants.UNIVERSAL_PROCESS_FILTER, IUniversalProcessDataStoreConstants.UNIVERSAL_PROCESS_ROOT, "", "", false); //$NON-NLS-1$ //$NON-NLS-2$
deObj.setAttribute(DE.A_SOURCE, filter.toString()); deObj.setAttribute(DE.A_SOURCE, filter.toString());
// query // query
DataElement queryCmd = ds.localDescriptorQuery(deObj.getDescriptor(), C_PROCESS_FILTER_QUERY_ALL); DataElement queryCmd = ds.localDescriptorQuery(deObj.getDescriptor(), IUniversalProcessDataStoreConstants.C_PROCESS_FILTER_QUERY_ALL);
if (queryCmd != null) if (queryCmd != null)
{ {
@ -198,7 +198,7 @@ public class DStoreProcessService extends AbstractProcessService implements IPro
} }
DataElement deObj = (DataElement) process.getObject(); DataElement deObj = (DataElement) process.getObject();
DataElement killCmd = ds.localDescriptorQuery(deObj.getDescriptor(), C_PROCESS_KILL); DataElement killCmd = ds.localDescriptorQuery(deObj.getDescriptor(), IUniversalProcessDataStoreConstants.C_PROCESS_KILL);
deObj.setAttribute(DE.A_SOURCE, signal); deObj.setAttribute(DE.A_SOURCE, signal);
if (killCmd != null) if (killCmd != null)
@ -341,9 +341,9 @@ public class DStoreProcessService extends AbstractProcessService implements IPro
{ {
DataStore ds = getDataStore(); DataStore ds = getDataStore();
DataElement encodingElement = ds.createObject(null, UNIVERSAL_PROCESS_TEMP, ""); //$NON-NLS-1$ DataElement encodingElement = ds.createObject(null, IUniversalProcessDataStoreConstants.UNIVERSAL_PROCESS_TEMP, ""); //$NON-NLS-1$
DataElement queryCmd = ds.localDescriptorQuery(encodingElement.getDescriptor(), C_PROCESS_QUERY_USERNAME); DataElement queryCmd = ds.localDescriptorQuery(encodingElement.getDescriptor(), IUniversalProcessDataStoreConstants.C_PROCESS_QUERY_USERNAME);
DStoreStatusMonitor monitor = getStatusMonitor(ds); DStoreStatusMonitor monitor = getStatusMonitor(ds);
DataElement status = ds.command(queryCmd, encodingElement, true); DataElement status = ds.command(queryCmd, encodingElement, true);
try try