mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-07 17:15:25 +02:00
Code Issues Wiki Activity

PR 51121, patch from Chris Wiebe to fix

Browse source 
and race condition.
This commit is contained in:
Alain Magloire 2004-02-03 18:08:58 +00:00
parent a26a745733
commit be766c6e3a
2 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
core/org.eclipse.cdt.ui/ChangeLog
View file

@ -1,3 +1,14 @@
2004-02-03 Alain Magloire
PR 51121
From Chris Wiebe:
This patch prevents a null pointer exception in
org.eclipse.jface.text.reconciler.AbstractReconciler. Under certain
conditions (like rapidly closing all editors) the call to getDocument()
inside initialProcess() can return null which causes an exception.
* src/org/eclipse/cdt/internal/ui/text/CSourceViewerConfiguration.java
2004-02-03 Alain Magloire 2004-02-03 Alain Magloire
PR 51115 PR 51115

10
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/CSourceViewerConfiguration.java
View file

@ -192,7 +192,15 @@ public class CSourceViewerConfiguration extends SourceViewerConfiguration {
*/ */
public IReconciler getReconciler(ISourceViewer sourceViewer) { public IReconciler getReconciler(ISourceViewer sourceViewer) {
if (fEditor != null && fEditor.isEditable()) { if (fEditor != null && fEditor.isEditable()) {
Reconciler reconciler= new Reconciler(); Reconciler reconciler= new Reconciler() {
protected void initialProcess() {
// prevent case where getDocument() returns null
// and causes exception in initialProcess()
IDocument doc = getDocument();
if (doc != null)
super.initialProcess();
}
};
reconciler.setDelay(1000); reconciler.setDelay(1000);
reconciler.setIsIncrementalReconciler(false); reconciler.setIsIncrementalReconciler(false);
reconciler.setReconcilingStrategy(new CReconcilingStrategy(fEditor), IDocument.DEFAULT_CONTENT_TYPE); reconciler.setReconcilingStrategy(new CReconcilingStrategy(fEditor), IDocument.DEFAULT_CONTENT_TYPE);