From c84e47a71143743b90dd9caca96855a3c7375536 Mon Sep 17 00:00:00 2001 From: Jonah Graham Date: Fri, 9 Sep 2022 14:50:00 -0400 Subject: [PATCH] Don't error when stack service in unavailable (#61) The only time the stack service is unavailable is: 1. Stack service hasn't been started yet 2. Stack service has been shutdown 3. Stack service never gets created All of these cases are configuration error, except (2). In (2) the stack service isn't available to do source lookup, so instead of an error, simply return no file (aka null) Fixes #53 --- .../dsf/debug/sourcelookup/DsfSourceLookupParticipant.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/sourcelookup/DsfSourceLookupParticipant.java b/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/sourcelookup/DsfSourceLookupParticipant.java index 77b0ab0808e..b0e81af0be2 100644 --- a/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/sourcelookup/DsfSourceLookupParticipant.java +++ b/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/debug/sourcelookup/DsfSourceLookupParticipant.java @@ -190,9 +190,7 @@ public class DsfSourceLookupParticipant extends AbstractSourceLookupParticipant IStack stackService = fServicesTracker.getService(IStack.class); if (stackService == null) { - rm.setStatus(new Status(IStatus.ERROR, DsfPlugin.PLUGIN_ID, IDsfStatusConstants.INVALID_HANDLE, - "Stack data not available", null)); //$NON-NLS-1$ - rm.done(); + rm.done((String) null); return; }