mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-16 21:45:22 +02:00
Code Issues Wiki Activity

launchbar: use LinkedHashMap to avoid random order

Browse source 
order of targets returned by target manager some-what important, use
linked hash maps everywhere to avoid randomness of hashmap

Change-Id: I670859854f10006c8591c3ebaa8f036d3127b5b8
This commit is contained in:
Alena Laskavaia 2016-01-11 14:47:25 -05:00
parent cec2cbf4dc
commit cd852c72c5
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
bundles/org.eclipse.launchbar.core/src/org/eclipse/launchbar/core/internal/target/LaunchTargetManager.java
View file

@ -8,7 +8,7 @@
package org.eclipse.launchbar.core.internal.target; package org.eclipse.launchbar.core.internal.target;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.HashMap; import java.util.LinkedHashMap;
import java.util.LinkedList; import java.util.LinkedList;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
@ -35,7 +35,7 @@ public class LaunchTargetManager implements ILaunchTargetManager {
private Map<String, Map<String, ILaunchTarget>> targets; private Map<String, Map<String, ILaunchTarget>> targets;
private Map<String, IConfigurationElement> typeElements; private Map<String, IConfigurationElement> typeElements;
private Map<String, ILaunchTargetProvider> typeProviders = new HashMap<>(); private Map<String, ILaunchTargetProvider> typeProviders = new LinkedHashMap<>();
private List<ILaunchTargetListener> listeners = new LinkedList<>(); private List<ILaunchTargetListener> listeners = new LinkedList<>();
private static final String DELIMETER1 = ","; //$NON-NLS-1$ private static final String DELIMETER1 = ","; //$NON-NLS-1$
@ -49,7 +49,7 @@ public class LaunchTargetManager implements ILaunchTargetManager {
private synchronized void initTargets() { private synchronized void initTargets() {
if (targets == null) { if (targets == null) {
// load target type elements from registry // load target type elements from registry
typeElements = new HashMap<>(); typeElements = new LinkedHashMap<>();
IExtensionRegistry registry = Platform.getExtensionRegistry(); IExtensionRegistry registry = Platform.getExtensionRegistry();
IExtensionPoint point = registry IExtensionPoint point = registry
.getExtensionPoint(Activator.getDefault().getBundle().getSymbolicName() + ".launchTargetTypes"); //$NON-NLS-1$ .getExtensionPoint(Activator.getDefault().getBundle().getSymbolicName() + ".launchTargetTypes"); //$NON-NLS-1$
@ -63,13 +63,13 @@ public class LaunchTargetManager implements ILaunchTargetManager {
} }
// load targets from preference store // load targets from preference store
targets = new HashMap<>(); targets = new LinkedHashMap<>();
Preferences prefs = getTargetsPref(); Preferences prefs = getTargetsPref();
try { try {
for (String typeId : prefs.keys()) { for (String typeId : prefs.keys()) {
Map<String, ILaunchTarget> type = targets.get(typeId); Map<String, ILaunchTarget> type = targets.get(typeId);
if (type == null) { if (type == null) {
type = new HashMap<>(); type = new LinkedHashMap<>();
targets.put(typeId, type); targets.put(typeId, type);
} }
@ -160,7 +160,7 @@ public class LaunchTargetManager implements ILaunchTargetManager {
initTargets(); initTargets();
Map<String, ILaunchTarget> type = targets.get(typeId); Map<String, ILaunchTarget> type = targets.get(typeId);
if (type == null) { if (type == null) {
type = new HashMap<>(); type = new LinkedHashMap<>();
targets.put(typeId, type); targets.put(typeId, type);
} }