From d7f5c2bd7cad5b922d205a1f3f832d7d07576d92 Mon Sep 17 00:00:00 2001 From: Alex Ruiz Date: Tue, 21 Feb 2012 15:18:56 -0800 Subject: [PATCH] Minor code cleanup. --- .../internal/checkers/externaltool/CppcheckOutputParser.java | 3 +-- .../internal/core/externaltool/ExternalToolInvokerTest.java | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/externaltool/CppcheckOutputParser.java b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/externaltool/CppcheckOutputParser.java index 81a237d65a9..53295324f18 100644 --- a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/externaltool/CppcheckOutputParser.java +++ b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/externaltool/CppcheckOutputParser.java @@ -29,7 +29,7 @@ import org.eclipse.core.resources.IFile; * @since 1.1 */ public class CppcheckOutputParser extends AbstractOutputParser { - // the pattern for parsing the message is: + // sample line to parse: // // [/src/HelloWorld.cpp:19]: (style) The scope of the variable 'i' can be reduced // ----------1--------- -2 --3-- ------------------4------------------------- @@ -39,7 +39,6 @@ public class CppcheckOutputParser extends AbstractOutputParser { // 2: line where problem was found // 3: problem severity // 4: problem description - private static Pattern pattern = Pattern.compile("\\[(.*):(\\d+)\\]:\\s*\\((.*)\\)\\s*(.*)"); //$NON-NLS-1$ private final InvocationParameters parameters; diff --git a/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/internal/core/externaltool/ExternalToolInvokerTest.java b/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/internal/core/externaltool/ExternalToolInvokerTest.java index 0aa87c66cb2..87f88f6f51c 100644 --- a/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/internal/core/externaltool/ExternalToolInvokerTest.java +++ b/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/internal/core/externaltool/ExternalToolInvokerTest.java @@ -102,7 +102,6 @@ public class ExternalToolInvokerTest extends CodanTestCase { // }; public void testInvokesProcessCorrectly() throws Throwable { String aboveComment = getAboveComment(); - System.out.println(aboveComment); loadcode(aboveComment); String expectedCommand = expectedCommand(); InvocationParameters parameters = new InvocationParameters(currentIFile, currentIFile,