mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

Bug 560038 - Mark LlvmResourceListener for deletion

Browse source 
- deleted LlvmResourceListener.java
- removed all references to LlvmResourceListener
- removed import of LlvmResourceListener
- bumped bundle version to 1.2.0 as per Alexander's advise
- added 2 commented filters wrt problems in MANNIFEST.MF

Change-Id: Iee8024dc6bfd6998b2eecbae25f7574bc3effba0
Signed-off-by: Joost Kraaijeveld <J.Kraaijeveld@Askesis.nl>
This commit is contained in:
Joost Kraaijeveld 2020-02-15 13:31:41 +01:00
parent dec2d14bad
commit da67b8d706
3 changed files with 14 additions and 72 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
llvm/org.eclipse.cdt.managedbuilder.llvm.ui/.settings/.api_filters
View file

@ -16,4 +16,18 @@
</message_arguments>
</filter>
</resource>
<resource path="META-INF/MANIFEST.MF" type="org.eclipse.cdt.managedbuilder.llvm.util.LlvmResourceListener">
<filter comment="Bug 560038 - Mark LlvmResourceListener for deletion" id="305324134">
<message_arguments>
<message_argument value="org.eclipse.cdt.managedbuilder.llvm.util.LlvmResourceListener"/>
<message_argument value="org.eclipse.cdt.managedbuilder.llvm.ui_1.1.200"/>
</message_arguments>
</filter>
<filter comment="Bug 560038 - Mark LlvmResourceListener for deletion" id="305324134">
<message_arguments>
<message_argument value="org.eclipse.cdt.managedbuilder.llvm.util.LlvmResourceListener"/>
<message_argument value="org.eclipse.cdt.managedbuilder.llvm.ui_1.2.0"/>
</message_arguments>
</filter>
</resource>
</component>

11
llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/ui/LlvmUIPlugin.java
View file

@ -20,10 +20,6 @@ import java.util.MissingResourceException;
import java.util.PropertyResourceBundle;
import java.util.ResourceBundle;
import org.eclipse.cdt.managedbuilder.llvm.util.LlvmResourceListener;
import org.eclipse.core.resources.IResourceChangeEvent;
import org.eclipse.core.resources.IResourceChangeListener;
import org.eclipse.core.resources.ResourcesPlugin;
import org.eclipse.core.runtime.FileLocator;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Path;
@ -54,10 +50,6 @@ public class LlvmUIPlugin extends AbstractUIPlugin {
//Property Resource bundle
private PropertyResourceBundle properties;
//Resource listeners
private IResourceChangeListener listener = new LlvmResourceListener();
private IResourceChangeListener listener2 = new LlvmResourceListener();
/**
* Constructor.
*/
@ -71,9 +63,6 @@ public class LlvmUIPlugin extends AbstractUIPlugin {
super.start(context);
plugin = this;
// LlvmEnvironmentVariableSupplier.initializePaths();
//add resource change listeners to the workspace
ResourcesPlugin.getWorkspace().addResourceChangeListener(this.listener, IResourceChangeEvent.PRE_BUILD);
ResourcesPlugin.getWorkspace().addResourceChangeListener(this.listener2, IResourceChangeEvent.POST_BUILD);
}
@Override

61
llvm/org.eclipse.cdt.managedbuilder.llvm.ui/src/org/eclipse/cdt/managedbuilder/llvm/util/LlvmResourceListener.java
View file

@ -1,61 +0,0 @@
/*******************************************************************************
* Copyright (c) 2010, 2015 Nokia Siemens Networks Oyj, Finland.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
* which accompanies this distribution, and is available at
* https://www.eclipse.org/legal/epl-2.0/
*
* SPDX-License-Identifier: EPL-2.0
*
* Contributors:
* Nokia Siemens Networks - initial implementation
* Petri Tuononen - Initial implementation
* Marc-Andre Laperle (Ericsson)
*******************************************************************************/
package org.eclipse.cdt.managedbuilder.llvm.util;
import org.eclipse.core.resources.IResourceChangeEvent;
import org.eclipse.core.resources.IResourceChangeListener;
/**
* Implements Resource listener.
*/
public class LlvmResourceListener implements IResourceChangeListener {
/**
* Defines what happens when resources have changed.
*
* @param event IResourceChangeEvent
*/
@Override
public void resourceChanged(IResourceChangeEvent event) {
if (event.getType() == IResourceChangeEvent.POST_BUILD) { //refresh every project after build
/*
* FIXME: M-A.L: (Bug 405909) I commented out the refresh code because it was a
* major performance issue even without LLVM projects in the
* workspace. Unfortunately, I could not track down the reason as to
* why there was a refresh in the first the place by looking at the
* history (git and svn) and by manual testing
*/
// //get all projects
// IProject[] projects = LlvmToolOptionPathUtil.getProjectsInWorkspace();
//
// //refresh the projects
// for (IProject proj : projects) {
// try {
// proj.refreshLocal(IResource.DEPTH_INFINITE, null);
// } catch (CoreException e) {
// e.printStackTrace();
// }
// }
} else {
return;
}
}
}