mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-11 18:25:40 +02:00
Code Issues Wiki Activity

Bug 350365: Remote attach session should use specified binary

Browse source
This commit is contained in:
Marc Khouzam 2011-06-29 11:49:37 -04:00
parent 842540e7dc
commit dbc8969164
1 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/actions/GdbConnectCommand.java
View file

@ -71,6 +71,8 @@ public class GdbConnectCommand implements IConnect {
// with the same name without having to be prompted each time for a path. // with the same name without having to be prompted each time for a path.
// This map is associated to the current debug session only, therefore the user can // This map is associated to the current debug session only, therefore the user can
// reset it by using a new debug session. // reset it by using a new debug session.
// This map is only needed for remote sessions, since we don't need to specify
// the binary location for a local attach session.
private Map<String, String> fProcessNameToBinaryMap = new HashMap<String, String>(); private Map<String, String> fProcessNameToBinaryMap = new HashMap<String, String>();
public GdbConnectCommand(DsfSession session) { public GdbConnectCommand(DsfSession session) {
@ -187,6 +189,23 @@ public class GdbConnectCommand implements IConnect {
@Override @Override
public IStatus runInUIThread(IProgressMonitor monitor) { public IStatus runInUIThread(IProgressMonitor monitor) {
// If this is the very first attach of a remote session, check if the user
// specified the binary in the launch. If so, let's add it to our map to
// avoid having to prompt the user for that binary.
// This would be particularly annoying since we didn't use to have
// to do that before we supported multi-process.
// Bug 350365
if (fProcessNameToBinaryMap.isEmpty()) {
IGDBBackend backend = fTracker.getService(IGDBBackend.class);
if (backend != null) {
IPath binaryPath = backend.getProgramPath();
if (binaryPath != null && !binaryPath.isEmpty()) {
fProcessNameToBinaryMap.put(binaryPath.lastSegment(), binaryPath.toOSString());
}
}
}
// Have we already see the binary for a process with this name? // Have we already see the binary for a process with this name?
String binaryPath = fProcessNameToBinaryMap.get(fProcName); String binaryPath = fProcessNameToBinaryMap.get(fProcName);