mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-15 04:55:22 +02:00
Code Issues Wiki Activity

[249482] Duplicate Filters can be created if changing the filter pool

Browse source
This commit is contained in:
David McKnight 2008-11-25 19:02:06 +00:00
parent 2f70d78f39
commit dc3c44e927
1 changed files with 73 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

76
rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/filters/dialogs/SystemNewFilterWizardNamePage.java
View file

@ -15,6 +15,7 @@
* David Dykstal (IBM) - [160403] filters should be connection private by default
* David McKnight (IBM) - [225506] [api][breaking] RSE UI leaks non-API types
* David McKnight (IBM) - [226948] [api][regression] SystemNewFilterWizard.createNamePage() is no longer available
* David McKnight (IBM) - [249482] Duplicate Filters can be created if changing the filter pool
*******************************************************************************/
package org.eclipse.rse.ui.filters.dialogs;
@ -310,22 +311,91 @@ public class SystemNewFilterWizardNamePage
if (src == poolCombo)
{
int selection = poolCombo.getSelectionIndex();
if ((selection >= 0) && (nameValidators!=null))
if ((selection >= 0) && (nameValidators!=null)){
nameValidator = nameValidators[selection];
ISystemFilterPool currentPool = poolsToSelectFrom[selection];
if (currentPool == parentPool){ // if this is the connection-unique filter pool, set the uniqueCB
uniqueCB.setSelection(true);
poolCombo.setEnabled(false);
}
}
}
else if (src == poolWrapperCombo)
{
int selection = poolWrapperCombo.getSelectionIndex();
if ((selection >= 0) && (nameValidators!=null))
if ((selection >= 0) && (nameValidators!=null)){
nameValidator = nameValidators[selection];
ISystemFilterPoolWrapper currentPool = poolWrappers[selection];
if (currentPool == poolWrapperInformation.getPreSelectWrapper()){ // if this is the connection-unique filter pool, set the uniqueCB
uniqueCB.setSelection(true);
poolWrapperCombo.setEnabled(false);
}
}
}
else if (src == uniqueCB)
{
boolean selected = uniqueCB.getSelection();
if (poolVerbiage != null)
poolVerbiage.setEnabled(!selected);
if (poolCombo != null)
if (poolCombo != null){
poolCombo.setEnabled(!selected);
// if unique to connection then only connection-private filter pool can be used
// if it's not unique to connection, then the connection-private filter pool should not be selected
boolean foundPool = false;
int filterPoolSelectionIndex = 0;
if (poolsToSelectFrom != null){
int currentIndex = poolCombo.getSelectionIndex();
ISystemFilterPool currentPool = poolsToSelectFrom[currentIndex];
if (currentPool != parentPool && !selected){
// then the current pool is okay
filterPoolSelectionIndex = currentIndex;
}
else {
for (int idx=0; idx<poolsToSelectFrom.length && !foundPool; idx++){
ISystemFilterPool pool = poolsToSelectFrom[idx];
boolean isConnectionUnique = pool == parentPool;
if ((isConnectionUnique && selected) || (!isConnectionUnique && !selected)){
filterPoolSelectionIndex = idx;
foundPool = true;
}
}
poolCombo.select(filterPoolSelectionIndex);
}
}
else if (poolWrappers != null){
int currentIndex = poolWrapperCombo.getSelectionIndex();
ISystemFilterPoolWrapper currentPoolWrapper = poolWrappers[currentIndex];
if (currentPoolWrapper == poolWrapperInformation.getPreSelectWrapper()){
// then the current pool is okay
filterPoolSelectionIndex = currentIndex;
}
else {
for (int idx=0; idx<poolWrappers.length && !foundPool; idx++){
boolean isConnectionUnique = poolWrapperInformation.getPreSelectWrapper() == poolWrappers[idx];
if ((isConnectionUnique && selected) || (!isConnectionUnique && !selected)){
filterPoolSelectionIndex = idx;
foundPool = true;
}
}
poolWrapperCombo.select(filterPoolSelectionIndex);
}
}
if (nameValidators != null){
nameValidator = nameValidators[filterPoolSelectionIndex];
}
}
if (poolWrapperCombo != null)
poolWrapperCombo.setEnabled(!selected);
if (poolComboLabel != null)