mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-08 17:45:24 +02:00
Code Issues Wiki Activity

[cleanup] Remove unnecessary implementations

Browse source
This commit is contained in:
Martin Oberhuber 2007-04-03 17:18:39 +00:00
parent a10fb47542
commit dcf70fe0b8
6 changed files with 16 additions and 212 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
rse/examples/org.eclipse.rse.examples.daytime/src/org/eclipse/rse/examples/daytime/subsystems/DaytimeSubSystemConfiguration.java
View file

@ -43,9 +43,6 @@ public class DaytimeSubSystemConfiguration extends ServiceSubSystemConfiguration
super(); super();
} }
public boolean supportsServerLaunchProperties(IHost host) {
return false;
}
public boolean supportsFilters() { public boolean supportsFilters() {
return false; return false;
} }
@ -103,12 +100,4 @@ public class DaytimeSubSystemConfiguration extends ServiceSubSystemConfiguration
return IDaytimeService.class; return IDaytimeService.class;
} }
/**
* By default, this type of subsystem supports deferred queries.
* Override this method if your implementation does not.
*/
public boolean supportsDeferredQueries()
{
return true;
}
} }

79
rse/plugins/org.eclipse.rse.subsystems.files.core/src/org/eclipse/rse/subsystems/files/core/subsystems/RemoteFileSubSystemConfiguration.java
View file

@ -56,6 +56,7 @@ public abstract class RemoteFileSubSystemConfiguration extends SubSystemConfigur
{ {
super(); super();
} }
/** /**
* Tell us if this is a unix-style file system or a windows-style file system. The * Tell us if this is a unix-style file system or a windows-style file system. The
* default is windows. * default is windows.
@ -65,6 +66,7 @@ public abstract class RemoteFileSubSystemConfiguration extends SubSystemConfigur
{ {
this.unixStyle = isUnixStyle; this.unixStyle = isUnixStyle;
} }
/** /**
* Tell us if this is a unix-style file system or a windows-style file system. The * Tell us if this is a unix-style file system or a windows-style file system. The
* default is windows. * default is windows.
@ -74,6 +76,7 @@ public abstract class RemoteFileSubSystemConfiguration extends SubSystemConfigur
{ {
return unixStyle; return unixStyle;
} }
/** /**
* Tell us if this file system is case sensitive. The default is isUnixStyle(), and so should * Tell us if this file system is case sensitive. The default is isUnixStyle(), and so should
* rarely need to be overridden. * rarely need to be overridden.
@ -82,6 +85,7 @@ public abstract class RemoteFileSubSystemConfiguration extends SubSystemConfigur
{ {
return isUnixStyle(); return isUnixStyle();
} }
/** /**
* Tell us if this subsystem factory supports targets, which are destinations for * Tell us if this subsystem factory supports targets, which are destinations for
* pushes and builds. Normally only true for file system factories. * pushes and builds. Normally only true for file system factories.
@ -91,14 +95,7 @@ public abstract class RemoteFileSubSystemConfiguration extends SubSystemConfigur
{ {
return true; return true;
} }
/**
* Tell us if this subsystem factory supports server launch properties, which allow the user
* to configure how the server-side code for these subsystems are started. There is a Server
* Launch Setting property page, with a pluggable composite, where users can configure these
* properties.
* <br> By default we return false.
*/
public abstract boolean supportsServerLaunchProperties(IHost host);
/** /**
* Return true if subsystems of this factory support the environment variables property. * Return true if subsystems of this factory support the environment variables property.
* Return true to show it, return false to hide it. We return true. * Return true to show it, return false to hide it. We return true.
@ -200,47 +197,6 @@ public abstract class RemoteFileSubSystemConfiguration extends SubSystemConfigur
// -------------------------------------------- // --------------------------------------------
// PARENT METHODS RELATED TO WHAT WE SUPPORT... // PARENT METHODS RELATED TO WHAT WE SUPPORT...
// -------------------------------------------- // --------------------------------------------
/**
* We return true.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsSubSystemConnect()
*/
public boolean supportsSubSystemConnect()
{
return true;
}
/**
* We return true.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#isPortEditable()
*/
public boolean isPortEditable()
{
return true;
}
/**
* We return false.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsCommands()
*/
public boolean supportsCommands()
{
return false;
}
/**
* We return false.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsProperties()
*/
public boolean supportsProperties()
{
return false;
}
/**
* We return true.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsFilters()
*/
public boolean supportsFilters()
{
return true;
}
/** /**
* Return true if filters of this subsystem factory support dropping into. * Return true if filters of this subsystem factory support dropping into.
@ -259,15 +215,6 @@ public abstract class RemoteFileSubSystemConfiguration extends SubSystemConfigur
return true; return true;
} }
/**
* We return supportsFilters()
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsNestedFilters()
*/
public boolean supportsNestedFilters()
{
return supportsFilters();
}
/** /**
* Return true if you support user-defined actions for the remote system objects returned from expansion of * Return true if you support user-defined actions for the remote system objects returned from expansion of
* subsystems created by this subsystem factory. * subsystems created by this subsystem factory.
@ -279,8 +226,6 @@ public abstract class RemoteFileSubSystemConfiguration extends SubSystemConfigur
return true; return true;
} }
/** /**
* Return true if you support user-defined/managed named file types * Return true if you support user-defined/managed named file types
* <p>We return true * <p>We return true
@ -477,11 +422,6 @@ public abstract class RemoteFileSubSystemConfiguration extends SubSystemConfigur
return "universal"; //$NON-NLS-1$ return "universal"; //$NON-NLS-1$
} }
/** /**
* Determines whether this factory is responsible for the creation of subsytems of the specified type * Determines whether this factory is responsible for the creation of subsytems of the specified type
* Subsystem factories should override this to indicate which subsystems they support. * Subsystem factories should override this to indicate which subsystems they support.
@ -495,13 +435,4 @@ public abstract class RemoteFileSubSystemConfiguration extends SubSystemConfigur
return isFor; return isFor;
} }
/**
* By default file subsystems support deferred queries
* Override this method if not.
*/
public boolean supportsDeferredQueries()
{
return true;
}
} }

74
rse/plugins/org.eclipse.rse.subsystems.processes.core/src/org/eclipse/rse/subsystems/processes/core/subsystem/impl/RemoteProcessSubSystemConfiguration.java
View file

@ -48,65 +48,11 @@ public abstract class RemoteProcessSubSystemConfiguration extends
// PARENT METHODS RELATED TO WHAT WE SUPPORT... // PARENT METHODS RELATED TO WHAT WE SUPPORT...
// -------------------------------------------- // --------------------------------------------
/**
* We return true.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsSubSystemConnect()
*/
public boolean supportsSubSystemConnect()
{
return true;
}
/**
* We return true.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#isPortEditable()
*/
public boolean isPortEditable()
{
return true;
}
/**
* We return false.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsCommands()
*/
public boolean supportsCommands()
{
return false;
}
/**
* We return false.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsProperties()
*/
public boolean supportsProperties()
{
return false;
}
/**
* We return true.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsFilters()
*/
public boolean supportsFilters()
{
return true;
}
/** /**
* We return false * We return false
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsNestedFilters() * @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsNestedFilters()
*/ */
public boolean supportsNestedFilters() public boolean supportsNestedFilters()
{
return false;
}
/**
* Return true if you support compile actions for the remote system objects returned from expansion of
* subsystems created by this subsystem factory.
* <p>
* By returning true, user sees a "Work with->Compile Commands..." action item in the popup menu for this
* subsystem. The action is supplied by the framework, but is populated using overridable methods in this subsystem.
* <p>We return true.
*/
public boolean supportsCompileActions()
{ {
return false; return false;
} }
@ -123,8 +69,6 @@ public abstract class RemoteProcessSubSystemConfiguration extends
return true; return true;
} }
// ------------------------------------------------------ // ------------------------------------------------------
// PARENT METHODS RELATED TO FILTERS... // PARENT METHODS RELATED TO FILTERS...
// ... ONLY INTERESTING IF supportsFilters() return true! // ... ONLY INTERESTING IF supportsFilters() return true!
@ -198,28 +142,10 @@ public abstract class RemoteProcessSubSystemConfiguration extends
return pool; return pool;
} }
/**
* Return the translated string to show in the property sheet for the type property.
*/
public String getTranslatedFilterTypeProperty(ISystemFilter selectedFilter)
{
return super.getTranslatedFilterTypeProperty(selectedFilter);
}
public ISystemValidator getPortValidator() public ISystemValidator getPortValidator()
{ {
ISystemValidator portValidator = new ValidatorServerPortInput(); ISystemValidator portValidator = new ValidatorServerPortInput();
return portValidator; return portValidator;
} }
/**
* By default, this type of subsystem supports deferred queries.
* Override this method if your implementation does not.
*/
public boolean supportsDeferredQueries()
{
return true;
}
} }

44
rse/plugins/org.eclipse.rse.subsystems.shells.core/src/org/eclipse/rse/subsystems/shells/core/subsystems/RemoteCmdSubSystemConfiguration.java
View file

@ -38,14 +38,6 @@ public abstract class RemoteCmdSubSystemConfiguration extends SubSystemConfigura
// -------------------------------------------- // --------------------------------------------
// PARENT METHODS RELATED TO WHAT WE SUPPORT... // PARENT METHODS RELATED TO WHAT WE SUPPORT...
// -------------------------------------------- // --------------------------------------------
/**
* We return true.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsSubSystemConnect()
*/
public boolean supportsSubSystemConnect()
{
return true;
}
/** /**
* Return true if the subsystem supports more than one filter string * Return true if the subsystem supports more than one filter string
@ -75,45 +67,31 @@ public abstract class RemoteCmdSubSystemConfiguration extends SubSystemConfigura
/** /**
* We return true. * We return true.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#isPortEditable()
*/
public boolean isPortEditable()
{
return true;
}
/**
* We return true.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsCommands() * @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsCommands()
*/ */
public boolean supportsCommands() public boolean supportsCommands()
{ {
return true; return true;
} }
/** /**
* We return false. * Test if filters are supported. We return <code>false</code>.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsProperties()
*/
public boolean supportsProperties()
{
return false;
}
/**
* We return true.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsFilters() * @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsFilters()
*/ */
public boolean supportsFilters() public boolean supportsFilters()
{ {
return false; return false;
} }
/** /**
* We return false * Test if nested filters are supported. We return <code>false</code>.
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsNestedFilters() * @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsNestedFilters()
*/ */
public boolean supportsNestedFilters() public boolean supportsNestedFilters()
{ {
return false; return false;
} }
/** /**
* Tell us if filter strings are case sensitive. The default is false. * Tell us if filter strings are case sensitive. The default is false.
*/ */
@ -121,6 +99,7 @@ public abstract class RemoteCmdSubSystemConfiguration extends SubSystemConfigura
{ {
return false; return false;
} }
/** /**
* Tell us if duplicate filter strings are supported. The default is true for command subsystem factories! * Tell us if duplicate filter strings are supported. The default is true for command subsystem factories!
*/ */
@ -161,9 +140,6 @@ public abstract class RemoteCmdSubSystemConfiguration extends SubSystemConfigura
return pool; return pool;
} }
/** /**
* Return the translated string to show in the property sheet for the type property. * Return the translated string to show in the property sheet for the type property.
*/ */
@ -184,12 +160,4 @@ public abstract class RemoteCmdSubSystemConfiguration extends SubSystemConfigura
return ";"; //$NON-NLS-1$ return ";"; //$NON-NLS-1$
} }
/**
* By default, deferred queries are not applicable to this type
* of subsystem.
*/
public boolean supportsDeferredQueries()
{
return false;
}
} }

4
rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java
View file

@ -217,6 +217,8 @@ public abstract class SubSystemConfiguration implements ISubSystemConfiguration
/** /**
* Return true if subsystem instances from this factory support getting and setting properties * Return true if subsystem instances from this factory support getting and setting properties
* <p>RETURNS FALSE BY DEFAULT. * <p>RETURNS FALSE BY DEFAULT.
*
* @return <code>false</code> to indicate that Properties are not supported by default.
*/ */
public boolean supportsProperties() public boolean supportsProperties()
{ {
@ -228,6 +230,8 @@ public abstract class SubSystemConfiguration implements ISubSystemConfiguration
* done for you automatically. Specifically, they * done for you automatically. Specifically, they
* will be saved and restored for you automatically. * will be saved and restored for you automatically.
* The default is to support filters. * The default is to support filters.
*
* @return <code>true</code> to indicate that Filters are supported by default.
*/ */
public boolean supportsFilters() { public boolean supportsFilters() {
return true; return true;

14
rse/tests/org.eclipse.rse.tests/src/org/eclipse/rse/tests/internal/testsubsystem/TestSubSystemConfiguration.java
View file

@ -75,18 +75,4 @@ public class TestSubSystemConfiguration extends SubSystemConfiguration implement
return "testSubSystemFilter"; //$NON-NLS-1$ return "testSubSystemFilter"; //$NON-NLS-1$
} }
/* (non-Javadoc)
* @see org.eclipse.rse.core.subsystems.SubSystemConfiguration#supportsServerLaunchProperties(org.eclipse.rse.core.model.IHost)
*/
public boolean supportsServerLaunchProperties(IHost host) {
return false;
}
/**
* By default, this type of subsystem supports deferred queries.
*/
public boolean supportsDeferredQueries()
{
return true;
}
} }