mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-25 18:05:33 +02:00
Code Issues Wiki Activity

[174789] [performance] Don't contribute Property Pages to Wizard automatically

Browse source
This commit is contained in:
Martin Oberhuber 2007-07-19 16:46:56 +00:00
parent 3d7f8ffedf
commit dd720e158a
3 changed files with 41 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/propertypages/ISystemConnectionWizardPropertyPage.java
View file

@ -12,17 +12,27 @@
* *
* Contributors: * Contributors:
* Martin Oberhuber (Wind River) - [184095] Replace systemTypeName by IRSESystemType * Martin Oberhuber (Wind River) - [184095] Replace systemTypeName by IRSESystemType
* Martin Oberhuber (Wind River) - [174789] [performance] Don't contribute Property Pages to Wizard automatically
********************************************************************************/ ********************************************************************************/
package org.eclipse.rse.ui.propertypages; package org.eclipse.rse.ui.propertypages;
import org.eclipse.jface.wizard.IWizard;
import org.eclipse.rse.core.IRSESystemType; import org.eclipse.rse.core.IRSESystemType;
import org.eclipse.rse.core.subsystems.IConnectorService; import org.eclipse.rse.core.subsystems.IConnectorService;
import org.eclipse.rse.core.subsystems.ISubSystemConfiguration; import org.eclipse.rse.core.subsystems.ISubSystemConfiguration;
import org.eclipse.rse.ui.view.SubSystemConfigurationAdapter;
/** /**
* interface for a property page that can be shown in the new connection wizard * interface for a property page that can be shown in the new connection wizard.
*
* @deprecated this class will likely be removed in the future, because the
* underlying mechanism of contributing property pages to a wizard
* does not scale since it activates unrelated plug-ins. Custom wizard
* pages should be contributed through
* {@link SubSystemConfigurationAdapter#getNewConnectionWizardPages(ISubSystemConfiguration, IWizard)}
* instead. See also Eclipse Bugzilla bug 197129.
*/ */
public interface ISystemConnectionWizardPropertyPage public interface ISystemConnectionWizardPropertyPage
{ {

36
rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/view/SubSystemConfigurationAdapter.java
View file

@ -15,6 +15,7 @@
* Martin Oberhuber (Wind River) - [186773] split ISystemRegistryUI from ISystemRegistry * Martin Oberhuber (Wind River) - [186773] split ISystemRegistryUI from ISystemRegistry
* Martin Oberhuber (Wind River) - [189123] Move renameSubSystemProfile() from UI to Core * Martin Oberhuber (Wind River) - [189123] Move renameSubSystemProfile() from UI to Core
* Martin Oberhuber (Wind River) - [190231] Remove UI-only code from SubSystemConfiguration * Martin Oberhuber (Wind River) - [190231] Remove UI-only code from SubSystemConfiguration
* Martin Oberhuber (Wind River) - [174789] [performance] Don't contribute Property Pages to Wizard automatically
********************************************************************************/ ********************************************************************************/
package org.eclipse.rse.ui.view; package org.eclipse.rse.ui.view;
@ -91,7 +92,6 @@ import org.eclipse.rse.ui.validators.ValidatorSpecialChar;
import org.eclipse.rse.ui.widgets.IServerLauncherForm; import org.eclipse.rse.ui.widgets.IServerLauncherForm;
import org.eclipse.rse.ui.widgets.RemoteServerLauncherForm; import org.eclipse.rse.ui.widgets.RemoteServerLauncherForm;
import org.eclipse.rse.ui.wizards.SubSystemServiceWizardPage; import org.eclipse.rse.ui.wizards.SubSystemServiceWizardPage;
import org.eclipse.rse.ui.wizards.SystemSubSystemsPropertiesWizardPage;
import org.eclipse.swt.graphics.Image; import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Shell; import org.eclipse.swt.widgets.Shell;
@ -200,23 +200,21 @@ public class SubSystemConfigurationAdapter implements ISubSystemConfigurationAda
SubSystemServiceWizardPage page = new SubSystemServiceWizardPage(wizard, config); SubSystemServiceWizardPage page = new SubSystemServiceWizardPage(wizard, config);
return new ISystemNewConnectionWizardPage[] {page}; return new ISystemNewConnectionWizardPage[] {page};
} }
else //MOB Removed due to performance issue -- see Eclipse Bugzilla bug 174789
{ // else
List pages = getSubSystemPropertyPages(config); // {
if (pages != null && pages.size() > 0) // List pages = getSubSystemPropertyPages(config);
{ // if (pages != null && pages.size() > 0)
SystemSubSystemsPropertiesWizardPage page = new SystemSubSystemsPropertiesWizardPage(wizard, config, pages); // {
return new ISystemNewConnectionWizardPage[] {page}; // SystemSubSystemsPropertiesWizardPage page = new SystemSubSystemsPropertiesWizardPage(wizard, config, pages);
} // return new ISystemNewConnectionWizardPage[] {page};
} // }
// }
return new ISystemNewConnectionWizardPage[0]; return new ISystemNewConnectionWizardPage[0];
} }
/* /*
* Return the form used in the subsyste property page. This default implementation returns Syste * Return the form used in the subsystem property page. This default implementation returns Syste
*/ */
public ISystemSubSystemPropertyPageCoreForm getSubSystemPropertyPageCoreFrom(ISubSystemConfiguration config, ISystemMessageLine msgLine, Object caller) public ISystemSubSystemPropertyPageCoreForm getSubSystemPropertyPageCoreFrom(ISubSystemConfiguration config, ISystemMessageLine msgLine, Object caller)
{ {
@ -226,6 +224,14 @@ public class SubSystemConfigurationAdapter implements ISubSystemConfigurationAda
/** /**
* Gets the list of property pages applicable for a subsystem associated with this subsystem configuration * Gets the list of property pages applicable for a subsystem associated with this subsystem configuration
* @return the list of subsystem property pages * @return the list of subsystem property pages
*
* @deprecated this method will likely be removed in the future, because the
* underlying mechanism of finding the registered property pages for a
* SubSystemConfiguration does not scale since it activates unrelated
* plug-ins. Existing Platform functionality for getting the list of
* property pages registered against a SubSystem should be used, once
* the SubSystem class is loaded -- but not by referencing the
* SubSystemConfiguration. See also Eclipse Bugzilla bug 197129.
*/ */
protected List getSubSystemPropertyPages(ISubSystemConfiguration config) protected List getSubSystemPropertyPages(ISubSystemConfiguration config)
{ {
@ -243,7 +249,7 @@ public class SubSystemConfigurationAdapter implements ISubSystemConfigurationAda
String objectClass = configurationElement.getAttribute("objectClass"); //$NON-NLS-1$ String objectClass = configurationElement.getAttribute("objectClass"); //$NON-NLS-1$
// The objectClass attribute is a) deprecated and b) optional. If null, do not // The objectClass attribute is a) deprecated and b) optional. If null, do not
// try to instanciate a class from it as it will lead to a NPE. It is very bad // try to instantiate a class from it as it will lead to a NPE. It is very bad
// style to let throw the exception and catch it with an empty catch block. If // style to let throw the exception and catch it with an empty catch block. If
// the debugger is configured to intercept NPE's, we end up always here. // the debugger is configured to intercept NPE's, we end up always here.
if (objectClass == null) continue; if (objectClass == null) continue;

10
rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/wizards/SystemSubSystemsPropertiesWizardPage.java
View file

@ -12,6 +12,7 @@
* *
* Contributors: * Contributors:
* Martin Oberhuber (Wind River) - [190231] Move ISubSystemPropertiesWizardPage from UI to Core * Martin Oberhuber (Wind River) - [190231] Move ISubSystemPropertiesWizardPage from UI to Core
* Martin Oberhuber (Wind River) - [174789] [performance] Don't contribute Property Pages to Wizard automatically
********************************************************************************/ ********************************************************************************/
package org.eclipse.rse.ui.wizards; package org.eclipse.rse.ui.wizards;
@ -28,6 +29,7 @@ import org.eclipse.rse.ui.ISystemVerifyListener;
import org.eclipse.rse.ui.SystemWidgetHelpers; import org.eclipse.rse.ui.SystemWidgetHelpers;
import org.eclipse.rse.ui.propertypages.ISystemConnectionWizardErrorUpdater; import org.eclipse.rse.ui.propertypages.ISystemConnectionWizardErrorUpdater;
import org.eclipse.rse.ui.propertypages.ISystemConnectionWizardPropertyPage; import org.eclipse.rse.ui.propertypages.ISystemConnectionWizardPropertyPage;
import org.eclipse.rse.ui.view.SubSystemConfigurationAdapter;
import org.eclipse.swt.SWT; import org.eclipse.swt.SWT;
import org.eclipse.swt.custom.CTabFolder; import org.eclipse.swt.custom.CTabFolder;
import org.eclipse.swt.custom.CTabItem; import org.eclipse.swt.custom.CTabItem;
@ -39,7 +41,13 @@ import org.eclipse.ui.dialogs.PropertyPage;
/** /**
* Wizard page that display the property pages for a given subsystem in the * Wizard page that display the property pages for a given subsystem in the
* connection * connection
* *
* @deprecated this class will likely be removed in the future, because the
* underlying mechanism of contributing property pages to a wizard
* does not scale since it activates unrelated plug-ins. Custom wizard
* pages should be contributed through
* {@link SubSystemConfigurationAdapter#getNewConnectionWizardPages(ISubSystemConfiguration, IWizard)}
* instead. See also Eclipse Bugzilla bug 197129.
*/ */
public class SystemSubSystemsPropertiesWizardPage public class SystemSubSystemsPropertiesWizardPage
extends AbstractSystemNewConnectionWizardPage extends AbstractSystemNewConnectionWizardPage