mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-01 13:25:45 +02:00
Code Issues Wiki Activity

Bug 384780 - No error is reported if a directory is specified as program

Browse source 
path.
This commit is contained in:
Mikhail Khodjaiants 2012-07-10 16:16:03 -04:00
parent 9dbd7f7213
commit e19147b554
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
launch/org.eclipse.cdt.launch/src/org/eclipse/cdt/launch/ui/CMainTab.java
View file

@ -498,6 +498,11 @@ public class CMainTab extends CAbstractMainTab {
// Notice that we don't check if exePath points to a valid executable since such // Notice that we don't check if exePath points to a valid executable since such
// check is too expensive to be done on the UI thread. // check is too expensive to be done on the UI thread.
// See "https://bugs.eclipse.org/bugs/show_bug.cgi?id=328012". // See "https://bugs.eclipse.org/bugs/show_bug.cgi?id=328012".
// We only verify that the program path represents a file.
if (!exePath.toFile().isFile()) {
setErrorMessage(fPreviouslyCheckedProgramErrorMsg = LaunchMessages.CMainTab_Selection_must_be_file);
return (fPreviouslyCheckedProgramIsValid = false);
}
} }
} }