mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-29 03:45:35 +02:00
Code Issues Wiki Activity

2004-08-26 Chris Wiebe

Browse source 
slight reduction in memory allocations
	* browser/org/eclipse/cdt/ui/browser/typeinfo/TypeSelectionDialog.hava
	* src/org/eclipse/cdt/internal/ui/wizards/classwizard/NewClassCodeGenerator.java
This commit is contained in:
Chris Wiebe 2004-08-26 20:45:24 +00:00
parent 45adcaed84
commit e47e1cf94a
2 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
core/org.eclipse.cdt.ui/browser/org/eclipse/cdt/ui/browser/typeinfo/TypeSelectionDialog.java
View file

@ -141,8 +141,7 @@ public class TypeSelectionDialog extends TwoPaneElementSelector {
private boolean matchQualifiedName(ITypeInfo info) { private boolean matchQualifiedName(ITypeInfo info) {
IQualifiedTypeName qualifiedName = info.getQualifiedTypeName(); IQualifiedTypeName qualifiedName = info.getQualifiedTypeName();
String[] segments = qualifiedName.segments(); if (fSegmentMatchers.length != qualifiedName.segmentCount())
if (fSegmentMatchers.length != segments.length)
return false; return false;
if (fMatchGlobalNamespace) { if (fMatchGlobalNamespace) {
@ -152,10 +151,10 @@ public class TypeSelectionDialog extends TwoPaneElementSelector {
} }
boolean matchFound = true; boolean matchFound = true;
int max = Math.min(fSegmentMatchers.length, segments.length); int max = Math.min(fSegmentMatchers.length, qualifiedName.segmentCount());
for (int i = 0; i < max; ++i) { for (int i = 0; i < max; ++i) {
StringMatcher matcher = fSegmentMatchers[i]; StringMatcher matcher = fSegmentMatchers[i];
String name = segments[i]; String name = qualifiedName.segment(i);
if (name == null || !matcher.match(name)) { if (name == null || !matcher.match(name)) {
matchFound = false; matchFound = false;
break; break;

8
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/wizards/classwizard/NewClassCodeGenerator.java
View file

@ -267,10 +267,9 @@ public class NewClassCodeGenerator {
return insertPos; return insertPos;
} }
private void beginNamespace(StringBuffer text) { private void beginNamespace(StringBuffer text) {
String[] segments = fNamespace.segments(); for (int i = 0; i < fNamespace.segmentCount(); ++i) {
for (int i = 0; i < segments.length; ++i) {
text.append("namespace "); //$NON-NLS-1$ text.append("namespace "); //$NON-NLS-1$
text.append(segments[i]); text.append(fNamespace.segment(i));
text.append(fLineDelimiter); text.append(fLineDelimiter);
text.append('{'); text.append('{');
text.append(fLineDelimiter); text.append(fLineDelimiter);
@ -279,8 +278,7 @@ public class NewClassCodeGenerator {
} }
private void endNamespace(StringBuffer text) { private void endNamespace(StringBuffer text) {
String[] segments = fNamespace.segments(); for (int i = 0; i < fNamespace.segmentCount(); ++i) {
for (int i = 0; i < segments.length; ++i) {
text.append(fLineDelimiter); text.append(fLineDelimiter);
text.append("};"); //$NON-NLS-1$ text.append("};"); //$NON-NLS-1$
text.append(fLineDelimiter); text.append(fLineDelimiter);