mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-07 01:36:01 +02:00
Code Issues Wiki Activity

Bug 505746 - A colon in the project name causes an NPE

Browse source 
Doubled column character addressed in this patch.

Change-Id: I942fbceeac231b2998fa808266f579509dc55295
This commit is contained in:
Marc Dumais 2016-10-12 13:18:39 -04:00 • committed by Gerrit Code Review @ Eclipse.org
parent 5da005cf3a
commit f8488ac157
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/FinalLaunchSequence.java
View file

@ -218,7 +218,7 @@ public class FinalLaunchSequence extends ReflectionSequence {
if (dir != null) { if (dir != null) {
fCommandControl.queueCommand( fCommandControl.queueCommand(
fCommandFactory.createMIEnvironmentCD(fCommandControl.getContext(), dir.toPortableString()), fCommandFactory.createMIEnvironmentCD(fCommandControl.getContext(), dir.toString()),
new DataRequestMonitor<MIInfo>(getExecutor(), requestMonitor)); new DataRequestMonitor<MIInfo>(getExecutor(), requestMonitor));
} else { } else {
requestMonitor.done(); requestMonitor.done();
@ -554,7 +554,6 @@ public class FinalLaunchSequence extends ReflectionSequence {
@Execute @Execute
public void stepNewProcess(final RequestMonitor rm) { public void stepNewProcess(final RequestMonitor rm) {
if (!fGDBBackend.getIsAttachSession()) { if (!fGDBBackend.getIsAttachSession()) {
boolean noBinarySpecified = CDebugUtils.getAttribute( boolean noBinarySpecified = CDebugUtils.getAttribute(
fAttributes, fAttributes,
IGDBLaunchConfigurationConstants.ATTR_DEBUGGER_USE_SOLIB_SYMBOLS_FOR_APP, IGDBLaunchConfigurationConstants.ATTR_DEBUGGER_USE_SOLIB_SYMBOLS_FOR_APP,
@ -563,7 +562,7 @@ public class FinalLaunchSequence extends ReflectionSequence {
String binary = null; String binary = null;
final IPath execPath = fGDBBackend.getProgramPath(); final IPath execPath = fGDBBackend.getProgramPath();
if (!noBinarySpecified && execPath != null && !execPath.isEmpty()) { if (!noBinarySpecified && execPath != null && !execPath.isEmpty()) {
binary = execPath.toPortableString(); binary = execPath.toString();
} }
// Even if binary is null, we must call this to do all the other steps // Even if binary is null, we must call this to do all the other steps