In the Multicore Visualizer, add the gdb thread ids so that users can
more easily recognize threads
Change-Id: I747e9223d9b689dd6a94d707dd2e5cfdb767764e
When using a `StringBuilder` or `StringBuffer` to create a string message,
using implicit string concatenation inside an `.append()` call will
create a nested StringBuilder for the purposes of creating the arguments,
which will subsequently be converted to a String and then passed to
the outer StringBuilder.
Skip the creation of the intermediate object and String by simply
replacing such calls with `buffer.append(a).append(b)`.
Where values are compile time String constants, leave as is so
that the javac compiler can perform compile-time String concatenation.
Ensure that NEWLINE isn't appended in such a way since it is not
a compile time constant `System.getProperty("line.separator")`
Change-Id: I4126aefb2272f06b08332e004d7ea76b6f02cdba
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
There are many opportunities for replacing `StringBuffer` with
`StringBuilder` provided that the type isn't visible from the
public API and is used only in internal methods. Replace these
where appropriate.
Change-Id: Ic2f50c5b6f3c3a4eae301bb3b40fb6faed235f79
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
In many cases a String's empty status is tested with `.equals("")`.
However, Java 1.6 added `.isEmpty()` which can be more efficient since
it compares the internal length parameter only for testing. Replace
code using the `.isEmpty()` variant instead.
Some tests for `"".equals(expr)` can be replaced with `expr.isEmpty()`
where it is already known that the `expr` is not null; however,
these have to be reviewed on a case-by-case basis.
Change-Id: I3c6af4d8b7638e757435914ac76cb3a67899a5fd
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
in preparation for the introduction of thread groups syntax in GDB,
thread id needs to be handled as a String.
Change-Id: I379a92de9755ba0532265519ee70d1e199de811b
Visualizer
This commit migrates the MulticoreVisualizer class to use the standard
DSF programming paradigm, which is to use RequestMonitors. It also
renames some methods to better fit in that programming model.
Change-Id: Ie00a5dcb810fb13a4ac526ff221cc10bd52a3fca
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
access some fields in MulticoreVisualizer class
Change-Id: Ib5a9141c77825a1f0fd9606d25503c245b397c1c
Reviewed-on: https://git.eclipse.org/r/37019
Reviewed-by: Marc Dumais <marc.dumais@ericsson.com>
Tested-by: Marc Dumais <marc.dumais@ericsson.com>
to debug view back to cloned MV view(s)
Change-Id: I16abf3022a2b4fa0478624c1a9a6b4589cbdc311
Reviewed-on: https://git.eclipse.org/r/36434
Tested-by: Hudson CI
Reviewed-by: William Swanson <WilliamRSwanson@gmail.com>
Reviewed-by: Marc Dumais <marc.dumais@ericsson.com>
Tested-by: Marc Dumais <marc.dumais@ericsson.com>
some other small non-functional improvements
Change-Id: I93e49b7158c916f349ad65ab3ba7d34e193b56c9
Reviewed-on: https://git.eclipse.org/r/35144
Reviewed-by: Marc Dumais <marc.dumais@ericsson.com>
Tested-by: Marc Dumais <marc.dumais@ericsson.com>
toolbar, when
pinned?
Change-Id: Ibde098fddcb6ba95322d6313edd0152d34932f93
Reviewed-on: https://git.eclipse.org/r/32177
Tested-by: Hudson CI
Reviewed-by: William Swanson <WilliamRSwanson@gmail.com>
Reviewed-by: Marc Dumais <marc.dumais@ericsson.com>
Tested-by: Marc Dumais <marc.dumais@ericsson.com>
possible
Change-Id: Ie47c21c35dc85d4efd34f273f8f0a51d4e82d16a
Reviewed-on: https://git.eclipse.org/r/31898
Reviewed-by: Marc Dumais <marc.dumais@ericsson.com>
Tested-by: Marc Dumais <marc.dumais@ericsson.com>
but debug session is still running
Change-Id: I3e9003cd34e990a71dac0e310f3e14a6eb54085e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/14051
selected in debug view
Change-Id: If1c7fdbdd08822175e83eebc9fcd51b6bd859aae
Reviewed-on: https://git.eclipse.org/r/13950
Reviewed-by: William Swanson <traveler@tilera.com>
IP-Clean: William Swanson <traveler@tilera.com>
Tested-by: William Swanson <traveler@tilera.com>
