1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Commit graph

34781 commits

Author SHA1 Message Date
Torbjörn Svensson
222a963f44 Minor updates to bundles to have proper translations
* Bundle-Vendor should be Eclipse CDT
* Added missing Bundle-Name attribute for some bundles
* Synced MANIFEST.MF and properties file for keys

Change-Id: I14e3b1cc35e7ae88a1585d8ab19cede682bd4fce
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-30 23:03:53 -04:00
Jonah Graham
0631233154 [releng] Add missing copyright headers to releng scripts
Change-Id: I68cdf1f8adc1e59f47bb610c8aaeb583ca6cf39b
2020-08-30 20:25:40 -04:00
Jonah Graham
7ed4974c39 Trivial - fix copyright year
Change-Id: I4ac2021ecc83f305884815a482e3640ae3f3b03a
2020-08-30 20:25:04 -04:00
Jonah Graham
6233337560 [releng] Split up check_code_cleanliness script
As more checks have been added it has gotten a little unweildy.

The new script "do_all_code_cleanups.sh" now does most of the code
formatting checks.

Change-Id: I65fd888c88e1d7e470ed5621cee18ff3bf6680b4
2020-08-30 20:09:50 -04:00
Jonah Graham
0cb1f7482a Bug 566511: [releng] Add missing UTF-8 encoding for all CDT projects
Includes updates to code cleanliness script

Change-Id: Ic495124285e3e002993f34dc12be5ad7337fe13b
2020-08-30 20:02:41 -04:00
jantje
4fd6a0f49f bug 560330 remove \${ "to not resolve" functionality
This change  causes incompatibility for users using the \${ to not
expand environment variables.

Tested with sloeber (700+ projects)

Change-Id: If327f055a41c309c475e17e0239a30e7518c3b23
Signed-off-by: jantje <eclipse@baeyens.it>
2020-08-30 16:42:17 -04:00
John Dallaway
7c57855e2f Bug 566462: Document deprecated GDB hardware debug API removal
Change-Id: I28458cae0513dbfe4fcab59f882f8f922b63bceb
2020-08-30 15:59:00 -04:00
Martin Weber
44ebe33262 Bug 566385: add cmake build-output parser.
Change-Id: I37af477454a7c587bcfdc470e9e54c6b3aa08a14
Signed-off-by: Martin Weber <fifteenknots505@gmail.com>
2020-08-30 13:18:26 +02:00
John Dallaway
eee4440071 Bug 566462: Eliminate deprecated network-oriented API
Device contributions should now extend DefaultGDBJtagConnectionImpl and
provide default connection details in the JTagDevice extension
declaration.

Launch configurations providing legacy connection data (ipAddress and
portNumber) are accommodated at launch and upgraded to use connection
URIs when edited.

Change-Id: I36b5d3e49f1d8f0becf1b898b7a48eb239453f1b
2020-08-29 13:39:54 -04:00
Torbjörn Svensson
4376632208 Fixed "Dead code" compiler warning
Change-Id: Idc18751d1bcd59a8fa49529731e11dce354b925a
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-28 21:19:14 -04:00
Torbjörn Svensson
f6016c5e0b Fixed "The value for X attribute is not externalized" warning
Change-Id: Ib2f0d85a0428a1f59cc7ccab6ebb8fd91ffa2a41
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-28 21:32:18 +02:00
Torbjörn Svensson
5779b04e6b Fixed "Key X is not found in localization properties file" warning
Change-Id: I467386ce652c67507c9373a669a60dbb8a8f8e2d
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-28 21:32:18 +02:00
Torbjörn Svensson
1f069898cf Fixed "Build entries must contain at least one value" warning
Change-Id: I47d8b76bc80f863d034044d2a0e4d9e84a335e29
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-28 21:32:18 +02:00
Torbjörn Svensson
cb9249314a Fixed "An entry for plugin.xml is required in bin.includes" warning
Change-Id: I6615465fb74c2e4df812e99cd1e5e8b0ead99de3
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-28 21:32:18 +02:00
Torbjörn Svensson
1c448e748e Fixed "An entry for OSGI-INF/ is required in bin.includes" warning
Change-Id: I0c1980995d7c53958067658474ba604bdaedb7a1
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-28 21:32:18 +02:00
Torbjörn Svensson
8e42cc8b7b Cleanup of PTY class
Change-Id: If04a3ccbc178040d4929767ef1f4c0f1672dfae9
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-28 10:25:08 -04:00
Torbjörn Svensson
38e970a45d Fixed "Unnecessary semicolon" compile warning
Change-Id: I6dc9bad163750f00be7046ebb9c18ae447ab9455
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-28 14:09:55 +02:00
John Dallaway
5188547f31 Bug 566462: Eliminate deprecated GDB hardware debug API
Change-Id: Ie0d5fa1beafaa0a203a9f4f043835b401cc6929d
2020-08-28 04:08:20 -04:00
Torbjörn Svensson
07b50ba2a2 Bug 521515: Do not rely on commit date for reproducible builds
As mentioned in
https://devblogs.microsoft.com/oldnewthing/20180103-00/?p=97705,
Microsoft has stopped using the _IMAGE_FILE_HEADER.TimeDateStamp as a
time stamp and rather as a hash of the source files to make the build
result predictable.

Change-Id: I4f4a7b9557330e4c478ef7fb25653144c5b2d4ad
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-27 15:42:44 -04:00
Jeff Johnston
2f05a6348e Bug 565142 - Support using CDT in Eclipse flatpak
- add missing @since tag for new CommandLauncherManager
  checkIfIncludesChanged method

Change-Id: Ic1774a464c08ee86ee594c4d80102457f79b0ea5
2020-08-26 15:46:15 -04:00
Alexander Fedorov
0349a8a85f Bug 566421 - CDT LSP should declare server as singleton
Mark "org.eclipse.cdt.lsp.core" contribution as singleton

Change-Id: If39a3b769f11d0cfda94857cc4d5b7bc6fff0df5
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-26 22:12:59 +03:00
Marc-Andre Laperle
b87c2a793d Bug 565553 - Improve performance of build command parsers with large number of files
Do not pretty-format *.language.settings.xml files in the workspace
plugin state area. These are not meant to be shared and looked by users
so they do not really need to be pretty-formatted. This saves a lot of
time for large projects with per-file language settings. For example, I
have seen this save 30 sec on a test project during serialization.

Change-Id: I27f8e0cfdc593f084d95bbed7aedb707570f1f6d
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2020-08-25 23:11:40 -04:00
Victor Rubezhny
2b67c0bda9 Bug 418579 - String index out of range: -8
Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Change-Id: I02763d18fdf8f9715670b671a7f84f9fe06489ca
2020-08-25 16:08:45 -04:00
Jeff Johnston
05c45c0bae Bug 565142 - Support using CDT in Eclipse flatpak
- modify ProcessFactory to prefix commands with flatpak-spawn
  when running under Eclipse flatpak
- add new FlatpakLaunch class to dsf.gdb to do a prelaunch
  of gdbserver and set up remote port settings when debugging
  local C/C++ application under Eclipse flatpak
- add new tab to gdb when running under Eclipse flatpak
  to allow user to specify gdbserver and port number
- add new org.eclipse.cdt.flatpak.launcher plug-in which
  contains a FlatpakCommandLauncherFactory to handle copying
  header files from host to workspace when developing under
  Eclipse flatpak
- add new FlatpakCommandLauncher class which simply extends
  CommandLauncher and can be used for debugging purposes to
  distinguish from regular command launcher
- also add new FlatpakHeaderPreferencePage to allow C/C++ users
  to delete copied headers if needed
- dynamically add the headers preference page from
FlatpakCommandLaunchFactory
  if running under Eclipse flatpak
- add new ICommandLaunchFactory3 to add an interface to check if
  headers have been modified/removed and scanner info refresh
  is required
- add new org.eclipse.cdt.flatpak.launcher-feature
- give higher priority to ContainerCommandLauncherFactory so if
  running on Eclipse flatpak, the flatpak factory won't be chosen
  if both apply (i.e. building in a container but running on
  Eclipse flatpak)

Change-Id: Id68e60c4dd37c4494af10440231ac7b7bbec8d17
2020-08-25 13:45:33 +03:00
Jonah Graham
aa5d565542 Bug 566339: Restore lost bundles to CDT's p2 repo
These were lost accidentally in commit 2bd07a89ca
In the restore version use the core PDE way of including bundles,
rather than Tycho's <iu> extension as we don't need the extended
capabilities and having an editor that works is nicer. See Bug 566340

Change-Id: If78d34737957c322b1d068840fc6f17883857070
2020-08-24 22:26:19 -04:00
Jonah Graham
0c5093d6ff Bug 566334: Turn on API Tooling & Analysis for all bundles
Change-Id: I3cb5645eba52b0cd0e9a71069264d9c589159107
2020-08-24 17:50:56 -04:00
Jonah Graham
fd9382d8a9 Bug 562494: Update BREE to Java 11
Change-Id: I0c91aafc0cb1b179936acbd4c9df2d961899e3fa
2020-08-24 17:50:56 -04:00
Marc-Andre Laperle
e933f46289 Bug 565553 - Improve performance of build command parsers with large number of files
Compile a pattern ahead of time and early return.

The first pattern is used to trim extra characters that are not
contained within the actual option pattern. If this first pattern
doesn't match, there is no point in continuing because it is a superset.

Times before/after, only counting AbstractOptionParser.parseOption
LLVM before: 4289ms, after: 622ms

Change-Id: Id40fc9a35359c39aea00ba14813ffe6c343158fc
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2020-08-23 23:21:14 -04:00
Marc-Andre Laperle
a9b67d0828 Bug 565553 - Improve performance of build command parsers with large number of files
Optimize MSVCBuildCommandParser.unescapeString.
Instead of running a Matcher/replaceAll every time, check first if the
string contains the characters to unescape first. Finding a substring in
a string is much faster than matching a pattern so this saves quite a
bit of time on large MSVC projects since many options will not have the
characters needed to be unescaped.

Change-Id: If2ad7892c29374458d5de446d4492ce3ba576c9c
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2020-08-23 23:18:40 -04:00
Marc-Andre Laperle
68c9b53de0 Bug 566107 - Option parsers can fail to trim extra characters when using patterns with numbered back-references
Clarify in the javadoc that numbered back-references should not be used
in order for option pattern to safely work.  Add a unit test
demonstrating the flaw when numbered back-references are used.  Update
GCC parser as an example for not using numbered back-references.

Change-Id: I008b3589486dc9fb0d9d9aa41f7cc2443bf4351e
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2020-08-23 21:33:05 -04:00
Alexander Fedorov
4f9d96f207 Bug 566286 - Rework CDT LSP Activator
Switch logging code to platform facilities

Change-Id: Iff6654ab6a55af898be8360ec0208ec7a0ddf977
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-23 10:16:33 -04:00
Jonah Graham
fbc117fd59 [releng] Update target platform Eclipse 4.17 M3
Change-Id: I5538eaa97b655137730f03a3be03af2e920e7b2e
2020-08-23 07:52:12 -04:00
Alexander Fedorov
147ff5a482 Bug 566093 - CDT LSP: null-free functions to retrieve URL from IDocument
Rework usages of Java 11 Optional#isEmpty() to Java 8
Optional#isPresent()

Change-Id: I9c0788414e7752efe87bf50eafadb6f3ab9a76be
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-23 05:32:41 -04:00
Torbjörn Svensson
e4e1f6780d Bug 565628: Unify line endings for memory block configuration
As the memory browser configuration is preserved in the launch
configuration file as an indented serialized XML string, the string will
contain the result of System.lineSeparator(). As the launch
configuration file can be shared among developers with different
platforms, there is a risk that the launch configuration file is always
modified although there is no real modification, just line endings.
To avoid this scenario, always save the XML string without any
indentation or line endings.

Change-Id: I94497a924f7aa5a881ac6a32f146d2cbceb6324f
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-22 11:33:02 -04:00
Alexander Fedorov
416a7f4f30 Bug 558592 - Rework access to PresentationReconcilerCPP
Move UI code to LSP UI bundle. Remove unused UI dependencies from LSP
Core bundle.
The Activator rework will follow with another Gerrit.

Change-Id: Ifb7e4d153dab6dcc7d50fdf60c2f22333abbb8ed
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-21 14:16:34 -04:00
Marc-Andre Laperle
2effd41b14 Mark Visual C++ Support feature as experimental
This feature was never really fully mature. It lacks important things
like proper built-in detection, ability to select VS version, target
architecture, Windows SDK, etc.  And now the supported VS versions are
quite behind. I have the intention to improve it over time but I think
it is better to set more reasonable expectations by flagging it as
experimental and it will also allow more ambitious but possibly
incompatible changes workspace-wise.

Change-Id: Iceaa316fb5cf17dde9a6f056d5ced1b3ce496c7f
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2020-08-21 12:40:35 -04:00
Alexander Fedorov
581eb9eb6d Bug 566237 - Remove CQuery support from CDT LSP feature
Removed "org.eclipse.cdt.lsp.cquery" bundle from "org.eclipse.cdt.lsp"
feature.

Change-Id: I076ce122bb612949f9e8efe7d868eb3a083ea4a0
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 21:12:42 +03:00
Alexander Fedorov
0bf22a2103 Bug 558664 - cquery and clangd: registered each LS from its own bundle
Part 13:
Add about.html and align headers.

Change-Id: I6c3fdfdbea65fbcc1e60a653ff6619afee916212
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 13:43:59 -04:00
Alexander Fedorov
df0e1d62b1 Bug 558664 - cquery and clangd: registered each LS from its own bundle
Part 12:
Extract cquery tests to org.eclipse.cdt.lsp.cquery.tests bundle.

Change-Id: I188fc5a0b06bccfeb0884c054c0d972226857b78
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 13:43:59 -04:00
Alexander Fedorov
fa03b9225b Bug 558664 - cquery and clangd: registered each LS from its own bundle
Part 11:
Move cquery code to org.eclipse.cdt.lsp.cquery bundle.

Change-Id: I079f08c1aa1c177abdc291402931f7547ab325bf
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 13:43:59 -04:00
Alexander Fedorov
b8427cb54a Bug 558664 - cquery and clangd: registered each LS from its own bundle
Part 10:
Move clangd code to org.eclipse.cdt.lsp.clangd bundle.

Change-Id: Ib2938ea34a4996a535658decc61a725f4626c649
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 13:43:59 -04:00
Alexander Fedorov
1fb6efa9c3 Bug 558664 - cquery and clangd: registered each LS from its own bundle
Part 9:
Add LSP clangd bundle.

Change-Id: I9274f56e7e2692f58b2a469007b1853b3e9c1d48
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 13:43:59 -04:00
Alexander Fedorov
8da8e068a5 Bug 558664 - Cquery integration should be extracted from LSP Core
Part 8:
Add LSP CQuery bundle.

Change-Id: Ie728716916b4d4ee854faec50925957f7d9436b5
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 13:43:59 -04:00
Alexander Fedorov
58e1b69c80 Bug 558664 - Cquery integration should be extracted from LSP Core
Part 7:
Extract CQuery protocol extension to its package and declare it as a
LanguageProtocolExtension component.
Remove custom "clientImpl" from LSP extension point, as we can use
standard one.
Declare DelegatingLauncherBuilder to collect and register language
extensions for the preferred language server.

Change-Id: I88be0456bbb53d24a6a0df2578c145649268b028
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 13:43:59 -04:00
Alexander Fedorov
3efcecf379 Bug 558664 - Cquery integration should be extracted from LSP Core
Part 6:
Declare SupportedProtocolExtensions interface to access contributed
LanguageProtocolExtension for a given language server.
Extract ResolvePreferredServer class.
Add ContributedProtocolExtensions OSGi component with tests.

Change-Id: Iecb1fff5a29a559e3c9d8703cc7d8fa71bb18042
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 13:43:59 -04:00
Alexander Fedorov
c609416622 Bug 558664 - Cquery integration should be extracted from LSP Core
Part 5:
Extract CQuery protocol methods to separate types.

Change-Id: I14f48ff4f374bd257adec67708bf58150993db21
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 13:43:59 -04:00
Alexander Fedorov
8abfaab458 Bug 558664 - Cquery integration should be extracted from LSP Core
Part 4:
Switch C/C++ LSP preferences to LanguageServerConfiguration and remove
constants with server identifiers. Align i18n accordingly.

Change-Id: I4dcd9ea57a2c4577bb6763bb859afbd339eb66e0
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 13:43:59 -04:00
Alexander Fedorov
3705069ef2 Bug 558664 - Cquery integration should be extracted from LSP Core
Part 3:
Convert ContributedLanguageServers to OSGi component and switch usages
to its interface.
Convert LanguageServerConfiguration implementations to OSGi components.

Change-Id: Ic22fa26a7abfd40a959ae0189a63b9a04d1ac4e0
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 13:43:59 -04:00
Alexander Fedorov
05ae2a8185 Bug 558664 - Cquery integration should be extracted from LSP Core
Part 2:
Introduce SupportedLanguageServers interface and remove knowledge about
specific language server from CPPStreamConnectionProvider. Replace
ICPPLanguageServer with LanguageServerConfiguration.
Move Clangd and Cquery server configurations to its packages.

Change-Id: I825c39bc6f8004616e639fda28660d3c98d08057
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 13:43:59 -04:00
Alexander Fedorov
afaa593d34 Bug 558664 - Cquery integration should be extracted from LSP Core
Part 1: rework "$cquery/progress" notification handling to be reusable

Change-Id: I6995594e51289e7f8a516ffc2cc2ec8bda88f919
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-08-20 13:43:59 -04:00