Some CDT preferences use \0 as a separator in preferences. Somewhere
in the Oomph preference synchronizer stack there is, or was, a place
that failed to escape/unescape preferences with encoded \0 properly.
CDT would then fail to parse the preference and an exception would
be raised, causing code completions and the editor to be broken.
This patch hardens the CDT code to:
(1) Allow an escaped \0 to be used as a separator on
read (Oomph uses ${0x0})
(2) Handle NumberFormatExceptions gracefully. In this case that means
showing user a pop-up that their completion preferences
are empty and offering to reset them, or edit them in preference
page. This UI logic already existed, so all the new code
has to do on failed parse is return a list of all disabled
completions.
Change-Id: Ibf3b05c0855bb96c195ca43139a50c27a2a90c7e
This removes use of internal API RenameResourceProcessor and removes
copying of code from platform's RenameResourceWizard to take advantage
of new UI API too.
Change-Id: I0e596027751dacf6982d4a63def617ae19f69827
Because of a bug in the platform implementation of equals/hashCode under
some circumstances, we can workaround the problem by returning
the same instance of CElementImageDescriptor when the objects are equal().
Change-Id: I6ff15cffa4b48080dcc6c9a023622edf4ae2d497
Switched from "org.eclipse.cdt.core.options" to
"org.eclipse.core.runtime.preferences"
Change-Id: Ie01d955079a7a54875270bb2d259c9232d30e7ea
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
The position of namespaces didn't take into account because the
declaration doesn't exist yet when we use this kind of refactoring,
so the find method of MethodDefinitionInsertLocationFinder didn't
look for namespaces.
Change-Id: I839194879c41f86653c837ca83a306ea1840c1d0
Some heuristics in skipToStatementStart require knowledge of previous
token. It is initialized with value from a fToken, but it current value
may be invalid because looksLikeMethodDecl changes fPossition value
without adjusting a fToken. Using invalid value may lead to false
triggering of heuristics. Restore fToken value when change fPossition in
looksLikeMethodDecl to prevent this.
Change-Id: If0c2c0577c89a983e1479587409f293c3d0db7be
Signed-off-by: Andrey Mozzhuhin <amozzhuhin@yandex.ru>
A function call may be mistakenly interpreted in looksLikeMethodDecl()
as a method declaration. This was due to simplified processing of
functions with a scope qualifiers in the name.
Now methods with a scope qualifier are handled similarly to methods
without them.
Change-Id: Id3075d3387fdf9c4ae2d0dffa6cdf923fd1ef9d5
Signed-off-by: Andrey Mozzhuhin <amozzhuhin@yandex.ru>
Scanning of double char tokens (::, >>, >=, <<, <=, ->) is broken in
nextToken(). In each case, peekNextChar() was used to get second
character, but scanner position was already on second char and
peekPreviousChar() need to be used.
Change-Id: Ibd447c7cde8783e8ffe547d5f9bc09d11c1c60a7
Signed-off-by: Andrey Mozzhuhin <amozzhuhin@yandex.ru>
- modify EditorUtility.getEditorInputForLocation() so that if we are
dealing with an external Include element and we can't get a
TranslationUnit then check the parent to find a contentTypeId and
create an appropriate ExternalTranslationUnit to use in creating
the ExternalEditorInput
Change-Id: Id99305606d058b8c105fe9b4099f5561620b07fd
Straightforward conversion. Still usages left that need deeper
investigation how to be done proper.
Some long time commented code removed as java formatter breaks trailing
whitespaces on save.
Change-Id: If74259bed5735b0d4cc98fc2cfa609c9c53c80c9
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
When the user selects the second wizard page was forced to use
a no empty variable name, however it's possible the parameter won't
be used and the user wants to have a matching signature. Removed
the check. The parameter name is still automatically set if the user
click directly on "Finish" button.
Change-Id: I665220b72d7b04b4bc89ffd5d764771cdfa8b243
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
If the correct namespace existed before the refactoring in the
translation unit, refactoring process just ignored it.
Change-Id: I9d6bd301807bb2d3f83f74ef772395d3470cf8bd
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
If an enum, a struct or a class is defined inside a class, the
implementation must qualify the declaration specifier.
Change-Id: I1e9450c7b165a25c4a745c50fe2e0c06e28775d0
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
Added org.eclipse.cdt.internal.ui.dialogs.DocCommentOwnerArea
Deprecated org.eclipse.cdt.ui.dialogs.DocCommentOwnerComposite
and marked it for deletion
Change-Id: I6ec1266fa0a7bce2e3fee43d1c4c2c0b3ba11ef7
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Reworked usages of DocCommentOwnerCombo and marked it for deletion
Change-Id: Ic1bfbcdb12512be0d2eed1ae93d454d7f1e5668f
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Part 2 (please refer to the Bug 559193 regarding the reasons to rework):
- Doxygen option read-only API for clients
- Doxygen option storage API for configuration UI
- OSGi component for Doxygen API implementation
Change-Id: Ia97ade397f1040087898aeb3b50872473d3c0631
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
The implementation of methods with parameter declaration or with
template template parameters didn't work.
Change-Id: I783dedc5ffecd6721293d52f13548fd9e73999bc
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
Reworked UI code to its natural contract.
Switched java 8 to compact the code
Encapsulated scope inside the DoxygenPreferences
Change-Id: I534b8d4f7c2d6e7674b132a10ef3514e61f2c1ed
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Choice is one of:
Kichwa Coders Ltd
Kichwa Coders Canada Inc.
depending if contributed by UK or Canadian company
Change-Id: I5c9fb96ea6abf97858a6896911a71fa68b8400b1
As part of trying to migrate SubProgressMonitor -> SubMonitor this code
was identified as being unreachable. As this dead code had a lot of
SubProgressMonitor it seems more suitable to just delete the dead
code rather than migrate it to SubMonitor API.
Change-Id: Idb9f96cb0d83ba0e7f617fab3bb6397e93824bba
Added autogeneration of documentation for template parameters,
exception speficiation.
Prepare Doxygen class to manage class names, struct names, union names
enum names and preprocessor define.
Change-Id: Id8689eac209cc509196a7c87ee286bb3e7c49e67
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
Support optional template type specification of return type in method
declaration deduction.
Change-Id: Ibaa5d5128faefb0b95534918ba9980bd8449b851
Signed-off-by: Andrey Mozzhuhin <amozzhuhin@yandex.ru>
